Rename hasOwner to ownedByEnvironment (#542)

Default to always checking Kind Environment instead
of passing a resource in.
This function is not used by any other controller or
to check anything but environment, so might as well

Author: t-persson

internal/controller/executionspace_controller.go

@@ -63,7 +63,7 @@ func (r *ExecutionSpaceReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 	}
 
 	// Ownership handoff: If Environment owns this ExecutionSpace, we relinquish control
-	if hasOwner(executionSpace.OwnerReferences, "Environment") {
+	if ownedByEnvironment(executionSpace.OwnerReferences) {
 		if controllerutil.ContainsFinalizer(executionSpace, providerFinalizer) {
 			// Clean up our finalizer since the environment controller now owns the ExecutionSpace
 			controllerutil.RemoveFinalizer(executionSpace, providerFinalizer)

internal/controller/iut_controller.go

@@ -63,7 +63,7 @@ func (r *IutReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 	}
 
 	// Ownership handoff: If Environment owns this IUT, we relinquish control
-	if hasOwner(iut.OwnerReferences, "Environment") {
+	if ownedByEnvironment(iut.OwnerReferences) {
 		if controllerutil.ContainsFinalizer(iut, providerFinalizer) {
 			// Clean up our finalizer since the environment controller now owns the IUT.
 			controllerutil.RemoveFinalizer(iut, providerFinalizer)

internal/controller/logarea_controller.go

@@ -63,7 +63,7 @@ func (r *LogAreaReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 	}
 
 	// Ownership handoff: If Environment owns this LogArea, we relinquish control
-	if hasOwner(logarea.OwnerReferences, "Environment") {
+	if ownedByEnvironment(logarea.OwnerReferences) {
 		if controllerutil.ContainsFinalizer(logarea, providerFinalizer) {
 			// Clean up our finalizer since the environment controller now owns the LogArea.
 			controllerutil.RemoveFinalizer(logarea, providerFinalizer)

internal/controller/utilities.go

@@ -47,8 +47,9 @@ const (
 	providerFinalizer = "etos.eiffel-community.github.io/managed-by-provider"
 )
 
-// hasOwner checks if a resource kind exists in ownerReferences.
-func hasOwner(ownerReferences []metav1.OwnerReference, kind string) bool {
+// ownedByEnvironment checks if an Environment resource exists in ownerReferences.
+func ownedByEnvironment(ownerReferences []metav1.OwnerReference) bool {
+	kind := "Environment"
 	for _, ownerReference := range ownerReferences {
 		if ownerReference.Kind == kind {
 			return true