New invoke api

Author: sleipnir

src/main/java/io/eigr/spawn/api/actors/ActorRef.java

@@ -54,24 +54,56 @@ public static ActorRef of(SpawnClient client, String system, String name, String
         return new ActorRef(client, system, name, parent);
     }
 
-    public <T extends GeneratedMessageV3> Object invoke(String cmd, Class<T> outputType) throws Exception {
-        Object res = invokeActor(cmd, Empty.getDefaultInstance(), outputType, Optional.empty());
-        return outputType.cast(res);
+    public <T extends GeneratedMessageV3> Optional<Object>  invoke(String cmd, Class<T> outputType) throws Exception {
+        Optional<Object> res = invokeActor(cmd, Empty.getDefaultInstance(), outputType, Optional.empty());
+        if(res.isPresent() ){
+            return Optional.of(outputType.cast(res.get()));
+        }
+
+        return res;
+    }
+
+    public <T extends GeneratedMessageV3> Optional<Object>  invoke(String cmd, Class<T> outputType, InvocationOpts opts) throws Exception {
+        Optional<Object> res = invokeActor(cmd, Empty.getDefaultInstance(), outputType, Optional.ofNullable(opts));
+        if(res.isPresent() ){
+            return Optional.of(outputType.cast(res.get()));
+        }
+
+        return res;
+    }
+
+    public <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Optional<Object> invoke(String cmd, S value, Class<T> outputType) throws Exception {
+        Optional<Object> res = invokeActor(cmd, value, outputType, Optional.empty());
+        if(res.isPresent() ){
+            return Optional.of(outputType.cast(res.get()));
+        }
+
+        return res;
+    }
+
+    public <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Optional<Object> invoke(String cmd, S value, Class<T> outputType, InvocationOpts opts) throws Exception {
+        Optional<Object> res = invokeActor(cmd, value, outputType, Optional.ofNullable(opts));
+        if(res.isPresent() ){
+            return Optional.of(outputType.cast(res.get()));
+        }
+
+        return res;
+    }
+
+    public <T extends GeneratedMessageV3> void  invokeAsync(String cmd, Class<T> outputType) throws Exception {
+        invokeActor(cmd, Empty.getDefaultInstance(), outputType, Optional.empty());
     }
 
-    public <T extends GeneratedMessageV3> Object invoke(String cmd, Class<T> outputType, Optional<InvocationOpts> opts) throws Exception {
-        Object res = invokeActor(cmd, Empty.getDefaultInstance(), outputType, opts);
-        return outputType.cast(res);
+    public <T extends GeneratedMessageV3> void invokeAsync(String cmd, Class<T> outputType, InvocationOpts opts) throws Exception {
+        invokeActor(cmd, Empty.getDefaultInstance(), outputType, Optional.ofNullable(opts));
     }
 
-    public <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Object invoke(String cmd, S value, Class<T> outputType) throws Exception {
-        Object res = invokeActor(cmd, value, outputType, Optional.empty());
-        return outputType.cast(res);
+    public <T extends GeneratedMessageV3, S extends GeneratedMessageV3> void invokeAsync(String cmd, S value, Class<T> outputType) throws Exception {
+        invokeActor(cmd, value, outputType, Optional.empty());
     }
 
-    public <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Object invoke(String cmd, S value, Class<T> outputType, Optional<InvocationOpts> opts) throws Exception {
-        Object res = invokeActor(cmd, value, outputType, opts);
-        return outputType.cast(res);
+    public <T extends GeneratedMessageV3, S extends GeneratedMessageV3> void invokeAsync(String cmd, S value, Class<T> outputType, InvocationOpts opts) throws Exception {
+        invokeActor(cmd, value, outputType, Optional.ofNullable(opts));
     }
 
     public String getActorSystem() {
@@ -113,7 +145,7 @@ private void spawnActor() throws Exception {
         this.client.spawn(req);
     }
 
-    private <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Object invokeActor(
+    private <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Optional<Object> invokeActor(
             String cmd, S argument, Class<T> outputType, Optional<InvocationOpts> options) throws Exception {
         Protocol.InvocationRequest.Builder invocationRequestBuilder = Protocol.InvocationRequest.newBuilder();
 
@@ -153,11 +185,11 @@ private <T extends GeneratedMessageV3, S extends GeneratedMessageV3> Object invo
                 throw new ActorNotFoundException();
             case OK:
                 if (resp.hasValue()) {
-                    return resp.getValue().unpack(outputType);
+                    return Optional.of(resp.getValue().unpack(outputType));
                 }
-                return null;
+                return Optional.empty();
         }
 
-        throw new ActorNotFoundException();
+        return Optional.empty();
     }
 }

src/test/java/io/eigr/spawn/SpawnTest.java

@@ -31,15 +31,19 @@ public void before() throws Exception {
     @Test
     public void testApp() throws Exception {
         ActorRef joeActor = spawnSystem.createActorRef("spawn-system", "test_joe");
+        assertNotNull(joeActor);
 
         Actor.Request msg = Actor.Request.newBuilder()
                 .setLanguage("erlang")
                 .build();
 
-        Actor.Reply reply =
-                (Actor.Reply) joeActor.invoke("setLanguage", msg, Actor.Reply.class, Optional.empty());
+        Optional<Object> maybeReply =
+               joeActor.invoke("setLanguage", msg, Actor.Reply.class);
 
-        assertNotNull(reply);
-        assertEquals("Hello From Java", reply.getResponse());
+        if (maybeReply.isPresent()) {
+            Actor.Reply reply = (Actor.Reply) maybeReply.get();
+            assertNotNull(reply);
+            assertEquals("Hello From Java", reply.getResponse());
+        }
     }
 }