fix: maps overrides should take priority (#197)

Author: Gyllsdorff

src/plugin.js

@@ -68,7 +68,7 @@ export async function load({
 	const config = await helpers.getDefaults(path);
 
 	const fetched = await fetchImportMaps([...config.map, ...pUrls]);
-	const mappings = pMaps.concat(fetched);
+	const mappings = fetched.concat(pMaps);
 
 	await importMapPlugin.load(mappings);
 }

tap-snapshots/test/plugin.js.test.cjs

@@ -5,6 +5,31 @@
  * Make sure to inspect the output below.  Do not ignore changes!
  */
 'use strict'
+exports[`test/plugin.js > TAP > plugin() - direct definitions import should override fetched import maps > import maps from direct definition 1`] = `
+// fixtures/modules/file/main.js
+import { html } from "https://cdn.eik.dev/lit-html/v3";
+import { css } from "https://cdn.eik.dev/lit-html/v1";
+import { LitElement } from "https://cdn.eik.dev/lit-element/v2";
+var Inner = class extends LitElement {
+  static get styles() {
+    return [
+      css\`
+        :host {
+          color: red;
+        }
+      \`
+    ];
+  }
+  render(world) {
+    return html\`<p>Hello \${world}!</p>\`;
+  }
+};
+export {
+  Inner as default
+};
+
+`
+
 exports[`test/plugin.js > TAP > plugin() - import map fetched from a URL > import maps from urls 1`] = `
 // fixtures/modules/file/main.js
 import { html } from "https://cdn.eik.dev/lit-html/v2";

test/plugin.js

@@ -23,6 +23,71 @@ const bufferToString = (buff) => {
 	return str.join("");
 };
 
+tap.test(
+	"plugin() - direct definitions import should override fetched import maps",
+	async (t) => {
+		const app = fastify();
+		app.server.keepAliveTimeout = 20;
+		app.get("/one", (request, reply) => {
+			reply.send({
+				imports: {
+					"lit-element": "https://cdn.eik.dev/lit-element/v2",
+				},
+			});
+		});
+		app.get("/two", (request, reply) => {
+			reply.send({
+				imports: {
+					"lit-html": "https://cdn.eik.dev/lit-html/v1",
+					"lit-html/lit-html": "https://cdn.eik.dev/lit-html/v2",
+				},
+			});
+		});
+		const address = await app.listen();
+
+		await fs.promises.writeFile(
+			path.join(process.cwd(), "eik.json"),
+			JSON.stringify({
+				name: "test",
+				server: "https://localhost",
+				version: "1.0.0",
+				files: "./dist",
+				"import-map": `${address}/one`,
+			}),
+		);
+
+		await plugin.load({
+			maps: [
+				{
+					imports: {
+						"lit-html/lit-html": "https://cdn.eik.dev/lit-html/v3",
+					},
+				},
+			],
+			urls: [`${address}/one`, `${address}/two`],
+		});
+
+		const result = await esbuild.build({
+			entryPoints: [file],
+			bundle: true,
+			format: "esm",
+			minify: false,
+			sourcemap: false,
+			target: ["esnext"],
+			plugins: [plugin.plugin()],
+			write: false,
+		});
+
+		const code = bufferToString(result.outputFiles);
+		t.matchSnapshot(clean(code), "import maps from direct definition");
+
+		plugin.clear();
+		await app.close();
+		await fs.promises.unlink(path.join(process.cwd(), "eik.json"));
+		t.end();
+	},
+);
+
 tap.test("plugin() - import map fetched from a URL", async (t) => {
 	const app = fastify();
 	app.server.keepAliveTimeout = 20;