Fix pre-approval leakage

eileenmcnaughton · eileenmcnaughton · commit 227a108a44cf · 2017-03-18T10:04:01.000+13:00
diff --git a/CRM/Core/Payment/OmnipayMultiProcessor.php b/CRM/Core/Payment/OmnipayMultiProcessor.php
@@ -866,7 +866,9 @@ protected function supportsPreApproval() {
     omnipaymultiprocessor_civicrm_managed($entities);
     foreach ($entities as $entity) {
       if ($entity['entity'] === 'payment_processor_type') {
-        if (!empty($entity['params']['supports_preapproval'])) {
+        if (
+        $entity['params']['name'] === $this->_paymentProcessor['payment_processor_type']
+        && !empty($entity['params']['supports_preapproval'])) {
           return TRUE;
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -866,7 +866,9 @@ protected function supportsPreApproval() {`
`866`	`866`	`omnipaymultiprocessor_civicrm_managed($entities);`
`867`	`867`	`foreach ($entities as $entity) {`
`868`	`868`	`if ($entity['entity'] === 'payment_processor_type') {`
`869`		`- if (!empty($entity['params']['supports_preapproval'])) {`
	`869`	`+ if (`
	`870`	`+ $entity['params']['name'] === $this->_paymentProcessor['payment_processor_type']`
	`871`	`+ && !empty($entity['params']['supports_preapproval'])) {`
`870`	`872`	`return TRUE;`
`871`	`873`	`}`
`872`	`874`	`}`