Marginal error handling

Author: eileenmcnaughton

CRM/Core/Payment/OmnipayMultiProcessor.php

@@ -731,7 +731,10 @@ public function queryPaymentPlans($params) {
   public function query($params) {
     $this->createGateway($this->_paymentProcessor['id']);
     $response = $this->gateway->query($params)->send();
-    return $response->getData();
+    if ($response->isSuccessful()) {
+      return $response->getData();
+    }
+    throw new CRM_Core_Exception('Failed to retrieve data');
   }
 
   /**

vendor/omnipay/authorizenet/src/Message/QueryBatchResponse.php

@@ -38,7 +38,12 @@ public function __construct(AbstractRequest $request, $data)
 
     public function isSuccessful()
     {
-        return 1 === $this->getResultCode();
+        return 'Ok' === $this->getResultCode();
+    }
+
+    public function getResultCode() {
+        $result = $this->xml2array($this->data->messages, TRUE);
+        return $result['messages'][0]['resultCode'];
     }
 
     public function getData() {