feat: allow generate command to generate a single DBC file
#295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows a user to run
cantool generate INPUT OUTPUT-DIRECTORY
where INPUT is either a path to a DBC file. Previously it was only
possible to provide INPUT as a directory containing DBC files.
N.B. When INPUT is a directory containing DBC files the generated
files are created in OUTPUT-DIRECTORY relative to where they are found
in INPUT.
As an example, given the following directory structure:
dbc/
powertrain/pt.dbc
steering/steer.dbc
brake/brake.dbc
A `cantool generate dbc/ gen/go` call will generate the following
structure:
gen/go/
powertrain/pt.dbc.go
steering/steer.dbc.go
brake/brake.dbc.go
However, when INPUT is a single DBC file it is generated directly in
OUTPUT-DIRECTORY with its basename as the stem.
`cantool generate dbc/steering/steer.dbc gen/go/steering` will
therefore generate the gen/go/steering/steer.dbc.go.
Jassob
force-pushed
the
feat/allow-generate-single-files
branch
from
9a2c194 to
b4ade07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows a user to run
where INPUT is either a path to a DBC file. Previously it was only
possible to provide INPUT as a directory containing DBC files.
N.B. When INPUT is a directory containing DBC files the generated
files are created in OUTPUT-DIRECTORY relative to where they are found
in INPUT.
As an example, given the following directory structure:
A
cantool generate dbc/ gen/gocall will generate the followingstructure:
However, when INPUT is a single DBC file it is generated directly in
OUTPUT-DIRECTORY with its basename as the stem.
cantool generate dbc/steering/steer.dbc gen/go/steeringwilltherefore generate the gen/go/steering/steer.dbc.go.
Inspired by #292 (thanks @bertaveira!)