add SKU to Item

Author: laf-rge

quickbooks/mixins.py

@@ -255,14 +255,26 @@ class ListMixin(object):
 
     @classmethod
     def all(cls, order_by="", start_position="", max_results=100, qb=None):
-        """
-        :param start_position:
-        :param max_results: The max number of entities that can be returned in a response is 1000.
-        :param qb:
-        :return: Returns list
-        """
-        return cls.where("", order_by=order_by, start_position=start_position,
-                         max_results=max_results, qb=qb)
+        """Returns list of objects containing all objects in the QuickBooks database"""
+        if qb is None:
+            qb = QuickBooks()
+
+        # For Item objects, we need to explicitly request the SKU field
+        if cls.qbo_object_name == "Item":
+            select = "SELECT *, Sku FROM {0}".format(cls.qbo_object_name)
+        else:
+            select = "SELECT * FROM {0}".format(cls.qbo_object_name)
+
+        if order_by:
+            select += " ORDER BY {0}".format(order_by)
+
+        if start_position:
+            select += " STARTPOSITION {0}".format(start_position)
+
+        if max_results:
+            select += " MAXRESULTS {0}".format(max_results)
+
+        return cls.query(select, qb=qb)
 
     @classmethod
     def filter(cls, order_by="", start_position="", max_results="", qb=None, **kwargs):

tests/integration/test_item.py

@@ -45,3 +45,22 @@ def test_create(self):
         self.assertEqual(query_item.IncomeAccountRef.value, self.income_account.Id)
         self.assertEqual(query_item.ExpenseAccountRef.value, self.expense_account.Id)
         self.assertEqual(query_item.AssetAccountRef.value, self.asset_account.Id)
+
+    def test_sku_in_all(self):
+        """Test that SKU is properly returned when using Item.all()"""
+        # First create an item with a SKU
+        unique_name = "Test SKU Item {0}".format(datetime.now().strftime('%d%H%M%S'))
+        item = Item()
+        item.Name = unique_name
+        item.Type = "Service"
+        item.Sku = "TEST_SKU_" + self.account_number
+        item.IncomeAccountRef = self.income_account.to_ref()
+        item.ExpenseAccountRef = self.expense_account.to_ref()
+        item.save(qb=self.qb_client)
+
+        # Now fetch all items and verify the SKU is present
+        items = Item.all(max_results=100, qb=self.qb_client)
+        found_item = next((i for i in items if i.Id == item.Id), None)
+        
+        self.assertIsNotNone(found_item, "Created item not found in Item.all() results")
+        self.assertEqual(found_item.Sku, "TEST_SKU_" + self.account_number)