-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
I have been using cy-verify-downloads version 0.2.4 for a while now, and I just noticed an unwanted behaviour.
I accidentally changed one of my test suites so that it would call verifyDownload with an empty string as a parameter. In that case the test would be marked as "pass", even though the file download was not actually tested. The log output in Cypress UI looked like this:
verifyDownload - Waiting for the file to be exist
task - isFileExist, /home/foobar/project/cypress/downloads
assert - The file has been downloaded successfully: expected true to be true
I think this is misleading behaviour. If "cy.verifyDownload" is called with an empty string, then the test case should fail.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed