Skip to content

Commit 798d83c

Browse files
authored
v3.3.2 (#1428)
* try and fix build_wheels * bump oneTBB version * prod SDist
1 parent 652a953 commit 798d83c

File tree

9 files changed

+13
-13
lines changed

9 files changed

+13
-13
lines changed

.github/workflows/build_wheels.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
run: |
4040
# FIXME: why doesn't scikit_build_core automatically download ninja?
4141
sudo apt-get update
42-
sudo apt-get install ninja-build
42+
sudo apt-get install ninja-build libtbb-dev
4343
pip wheel dist/*.tar.gz
4444
- uses: actions/upload-artifact@v4
4545
with:

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ include(CMakeDependentOption)
3030
# Define Manifold version
3131
set(MANIFOLD_VERSION_MAJOR 3)
3232
set(MANIFOLD_VERSION_MINOR 3)
33-
set(MANIFOLD_VERSION_PATCH 1)
33+
set(MANIFOLD_VERSION_PATCH 2)
3434
set(
3535
MANIFOLD_VERSION
3636
"${MANIFOLD_VERSION_MAJOR}.${MANIFOLD_VERSION_MINOR}.${MANIFOLD_VERSION_PATCH}"

RELEASE_CHECKLIST.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
1. Make a new branch called the version, e.g. v2.3.0.
77
1. Use VSCode to search and replace the old version with the new - so far in test-cmake.sh, flake.nix, pyproject.toml, and package.json.
88
1. Also update CMakeLists.txt version by searching for "set(MANIFOLD_VERSION_".
9-
1. Commit, push, open a PR, verify tests pass, manually trigger PyPI CI, merge.
9+
1. Commit, push, open a PR, verify tests pass, manually trigger build_wheels CI, merge.
1010
1. On Github, draft a new release, make a new tag with the version number, add release notes, and publish.
1111
1. Check the Actions and verify that both PyPI and npm publishing actions ran successfully.
1212
1. Verify the npm [package](https://www.npmjs.com/package/manifold-3d?activeTab=code) looks good - unpacked size should be close to 1MB.

bindings/wasm/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bindings/wasm/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "manifold-3d",
3-
"version": "3.3.1",
3+
"version": "3.3.2",
44
"description": "Geometry library for topological robustness",
55
"main": "manifold.js",
66
"bin": {

cmake/manifoldDeps.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ if(MANIFOLD_PAR)
7272
FetchContent_Declare(
7373
TBB
7474
GIT_REPOSITORY https://github.com/oneapi-src/oneTBB.git
75-
GIT_TAG v2022.0.0
75+
GIT_TAG v2022.3.0
7676
GIT_PROGRESS TRUE
7777
)
7878
FetchContent_MakeAvailable(TBB)

flake.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
flake-utils.lib.eachDefaultSystem
3030
(system:
3131
let
32-
manifold-version = "3.3.1";
32+
manifold-version = "3.3.2";
3333
pkgs = import nixpkgs {
3434
inherit system;
3535
overlays = [

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "manifold3d"
3-
version = "3.3.1"
3+
version = "3.3.2"
44
authors = [
55
{ name="Emmett Lalish", email="elalish@gmail.com" },
66
]
@@ -58,10 +58,10 @@ musllinux-x86_64-image = "musllinux_1_2"
5858
skip = ["*-win32", "*_i686", "pp*", "*-musllinux*"]
5959

6060
# only clone TBB once
61-
before-all = "git clone --depth 1 --branch v2021.10.0 https://github.com/oneapi-src/oneTBB.git"
61+
before-all = "git clone --depth 1 --branch v2022.3.0 https://github.com/oneapi-src/oneTBB.git"
6262
[tool.cibuildwheel.config-settings]
6363
"cmake.define.FETCHCONTENT_SOURCE_DIR_TBB" = "./oneTBB"
64-
"cmake.define.MANIFOLD_DOWNLOADS" = "OFF"
64+
"cmake.define.MANIFOLD_USE_BUILTIN_TBB" = "ON"
6565

6666
[tool.cibuildwheel.macos]
6767
environment = "MACOSX_DEPLOYMENT_TARGET=10.14"

scripts/test-cmake.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ cd cmake-consumer
55
cat <<EOT > CMakeLists.txt
66
cmake_minimum_required(VERSION 3.18)
77
project(testing LANGUAGES CXX)
8-
find_package(manifold "3.3.1" REQUIRED)
8+
find_package(manifold "3.3.2" REQUIRED)
99
add_executable(testing test.cpp)
1010
target_link_libraries(testing PRIVATE manifold::manifold)
1111
EOT
@@ -14,7 +14,7 @@ cat <<EOT > test.cpp
1414
#include <manifold/manifold.h>
1515
#include <manifold/version.h>
1616
17-
#if MANIFOLD_VERSION < MANIFOLD_VERSION_NUMBER(3, 3, 1)
17+
#if MANIFOLD_VERSION < MANIFOLD_VERSION_NUMBER(3, 3, 2)
1818
# error "Unexpected: minimum version number not available"
1919
#endif
2020

0 commit comments

Comments
 (0)