Commands do not work + missing UI

[strnglp]

Running electron-22 branch from the tip or the last tagged release the client seems not quite in working order.

1. ? icon isn't there in the bottom right
2. : prefix commands do not work

I tried to build master but it fails downloading an older electron.

[ondreian]

Which : commands did you try?

[strnglp]

All of them. I am using the electron-22 branch and I noticed :config and :theme doesn't appear in the code anymore? It used to be in a folder called vimish in the master branch. I had assumed you refactored significantly and haven't gotten around to reintroducing the concept.

Note I also tried the release zips and had the same result.

[strnglp]

Is this still actively developed? Does it work for you?

[ondreian]

I am working on some things on my localhost, I use it as my daily driver for an FE, but I pruned a lot of stuff back because the scope had creeped a bit in several places.

[strnglp]

Understood, if you do wind up pushing the changes up I'd be happy to test and attempt bug fixes. I think what you've built is great and gives players options. For instance I want to run this in linux and I don't know of any other options.

[ondreian]

I will see about syncing up my changes tonight or tomorrow morning. 🙂

…

On Thu, Jul 20, 2023, 18:54 strnglp ***@***.***> wrote: Understood, if you do wind up pushing the changes up I'd be happy to test and attempt bug fixes. I think what you've built is great and gives players options. For instance I want to run this in linux and I don't know of any other options. — Reply to this email directly, view it on GitHub <#249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIKHASMPL2LUA7UVASHHEDXRHHM7ANCNFSM6AAAAAAYQ5TBMM> . You are receiving this because you commented.Message ID: ***@***.***>

[litch]

Gentle nudge on this thanks! Looks like a pretty intense project to be sure but something it may be fun to see more progress on.

[ondreian]

If you are using modern lich, it will autodetect the session and connect if active.

[litch]

Right. Connects just fine, but the previously-documented :commands don't work, and none of the theme switching seems to work. I've been able to go in and monkey with some of the TS and CSS and have it looking & feeling nicer. I kind of got the impression that you did a bunch of work to bring it to compliance with electron-22, but wound up with a massive amount of cruft around, but the "happy path" of it generally works for you, which is cool.

[ondreian]

yes, the added overhead of refactoring all of the themes was not something I am interested in right now, when i work on it i try to add novel features. There is a significant need for several of the commands to be refactored to the new electron security policies as well.

…

On Thu, Oct 12, 2023, 13:27 Justin Litchfield ***@***.***> wrote: Right. Connects just fine, but the previously-documented :commands don't work, and none of the theme switching seems to work. I've been able to go in and monkey with some of the TS and CSS and have it looking & feeling nicer. I kind of got the impression that you did a bunch of work to bring it to compliance with electron-22, but wound up with a massive amount of cruft around, but the "happy path" of it generally works for you, which is cool. — Reply to this email directly, view it on GitHub <#249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIKHAUE3YGVJRACNMKTB7LX7BACTAVCNFSM6AAAAAAYQ5TBMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRQGI2DKMBTHE> . You are receiving this because you commented.Message ID: ***@***.***>

[litch]

Yes that makes sense. You mentioned using it as your daily driver, is that a branch that you've just got local that you're using actively? I did a fair amount of rework on the UI and it feels a lot nicer to me, but would be interested in actual feature work that may be interesting (more nimble highlights?)

[ondreian]

Fairly sure it's the current electron-22 branch right now, what do you mean by nimble? I'm not opposed to PRs 😄

…

On Fri, Oct 13, 2023 at 11:03 AM Justin Litchfield ***@***.***> wrote: Yes that makes sense. You mentioned using it as your daily driver, is that a branch that you've just got local that you're using actively? I did a fair amount of rework on the UI and it feels a lot nicer *to me*, but would be interested in actual feature work that may be interesting (more nimble highlights?) — Reply to this email directly, view it on GitHub <#249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIKHAXJPMTPSEEG2QY3R63X7FX4RAVCNFSM6AAAAAAYQ5TBMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRHAZTAMRVGQ> . You are receiving this because you commented.Message ID: ***@***.***>