Skip to content

Commit 7436fe6

Browse files
committed
GUI BugFix => get only activated metrics on call getAllMetrics method
1 parent 1d563f4 commit 7436fe6

File tree

2 files changed

+31
-29
lines changed

2 files changed

+31
-29
lines changed

elastest-torm-gui/src/app/elastest-etm/etm-monitoring-view/etm-chart-group/etm-chart-group.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ export class EtmChartGroupComponent implements OnInit, AfterViewInit, AfterViewC
267267
let defaultMetricName: string = 'test' + '_' + 'et_dockbeat' + '_' + 'cpu_totalUsage'; // Activate Test cpu usage as default in AIO
268268
this.allInOneMetrics.activateAndApplyByName(defaultMetricName);
269269
if (!this.live) {
270-
this.allInOneMetrics.getAllMetrics();
270+
this.allInOneMetrics.getAllMetrics(false);
271271
}
272272
}
273273

elastest-torm-gui/src/app/shared/metrics-view/metrics-chart-card/models/es-rab-complex-metrics-model.ts

Lines changed: 30 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -147,35 +147,37 @@ export class ESRabComplexMetricsModel extends ComplexMetricsModel {
147147
this.yRightTwoAxisTickFormatting = yRightTwoAxisTickFormatting;
148148
}
149149

150-
getAllMetrics(): void {
150+
getAllMetrics(onlyActivated: boolean = true): void {
151151
for (let metric of this.allMetricsFields.fieldsList) {
152-
this.monitoringService
153-
.getAllMetrics(this.monitoringIndex, metric, undefined, this.startDate, this.endDate)
154-
.subscribe((data: LineChartMetricModel[]) => {
155-
switch (metric.unit) {
156-
case this.rightChartOneChartUnit:
157-
this.rightChartOneAllData = this.rightChartOneAllData.concat(data);
158-
if (metric.activated) {
159-
this.rightChartOne = this.rightChartOne.concat(data);
160-
}
161-
break;
162-
case this.leftChartUnit:
163-
this.leftChartAllData = this.leftChartAllData.concat(data);
164-
if (metric.activated) {
165-
this.leftChart = this.leftChart.concat(data);
166-
}
167-
break;
168-
case this.rightChartTwoChartUnit:
169-
this.rightChartTwoAllData = this.rightChartTwoAllData.concat(data);
170-
if (metric.activated) {
171-
this.rightChartTwo = this.rightChartTwo.concat(data);
172-
}
173-
break;
174-
default:
175-
break;
176-
}
177-
});
178-
// }
152+
if (!onlyActivated || (onlyActivated && metric.activated)) {
153+
this.monitoringService
154+
.getAllMetrics(this.monitoringIndex, metric, undefined, this.startDate, this.endDate)
155+
.subscribe((data: LineChartMetricModel[]) => {
156+
switch (metric.unit) {
157+
case this.rightChartOneChartUnit:
158+
this.rightChartOneAllData = this.rightChartOneAllData.concat(data);
159+
if (metric.activated) {
160+
this.rightChartOne = this.rightChartOne.concat(data);
161+
}
162+
break;
163+
case this.leftChartUnit:
164+
this.leftChartAllData = this.leftChartAllData.concat(data);
165+
if (metric.activated) {
166+
this.leftChart = this.leftChart.concat(data);
167+
}
168+
break;
169+
case this.rightChartTwoChartUnit:
170+
this.rightChartTwoAllData = this.rightChartTwoAllData.concat(data);
171+
if (metric.activated) {
172+
this.rightChartTwo = this.rightChartTwo.concat(data);
173+
}
174+
break;
175+
default:
176+
break;
177+
}
178+
});
179+
// }
180+
}
179181
}
180182
}
181183

0 commit comments

Comments
 (0)