Support building with Java 10 (#53)

Java 9 and it's compiler are EOL

Author: felixbarny

pom.xml

@@ -78,13 +78,17 @@
     </distributionManagement>
 
     <profiles>
+        <!--
+        This profile is needed to be active in IntelliJ
+        as it does not understand that the tests have a different target version
+        -->
         <profile>
-            <id>java9</id>
+            <id>IntelliJ</id>
             <activation>
                 <activeByDefault>false</activeByDefault>
             </activation>
             <properties>
-                <maven.compiler.target>9</maven.compiler.target>
+                <maven.compiler.target>10</maven.compiler.target>
             </properties>
         </profile>
         <profile>
@@ -115,9 +119,7 @@
         <profile>
             <id>errorprone</id>
             <activation>
-                <property>
-                    <name>maven.compiler.errorprone</name>
-                </property>
+                <activeByDefault>false</activeByDefault>
             </activation>
             <build>
                 <plugins>
@@ -223,6 +225,18 @@
                         </goals>
                     </execution>
                 </executions>
+                <dependencies>
+                    <!--
+                    The transitive dependency has version 3.5,
+                    which is not compatible with Java 10.
+                    TODO Remove this when updating the javadoc plugin version.
+                    -->
+                    <dependency>
+                        <groupId>org.apache.commons</groupId>
+                        <artifactId>commons-lang3</artifactId>
+                        <version>3.7</version>
+                    </dependency>
+                </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -236,6 +250,7 @@
                     </execution>
                 </executions>
             </plugin>
+            <!-- Check that we don't accidentally use features only available in Java 8+ -->
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>animal-sniffer-maven-plugin</artifactId>
@@ -261,7 +276,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-enforcer-plugin</artifactId>
-                <version>1.3.1</version>
+                <version>3.0.0-M1</version>
                 <executions>
                     <execution>
                         <id>enforce-java</id>
@@ -303,7 +318,7 @@
             <plugin>
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
-                <version>0.8.0</version>
+                <version>0.8.1</version>
                 <executions>
                     <execution>
                         <goals>