Skip to content

Commit 03e60d1

Browse files
build: bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.4.1 (#3926)
1 parent ec88d18 commit 03e60d1

File tree

11 files changed

+12
-33
lines changed

11 files changed

+12
-33
lines changed

apm-agent-plugins/apm-spring-resttemplate/apm-spring-restclient-test/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<dependency>
2121
<groupId>org.springframework.boot</groupId>
2222
<artifactId>spring-boot-dependencies</artifactId>
23-
<version>3.4.0</version>
23+
<version>3.4.1</version>
2424
<type>pom</type>
2525
<scope>import</scope>
2626
</dependency>

apm-agent-plugins/apm-spring-resttemplate/apm-spring-resttemplate-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<!-- Import dependency management from Spring Boot -->
2424
<groupId>org.springframework.boot</groupId>
2525
<artifactId>spring-boot-dependencies</artifactId>
26-
<version>3.4.0</version> <!-- update IT in case of major upgrade -->
26+
<version>3.4.1</version> <!-- update IT in case of major upgrade -->
2727
<type>pom</type>
2828
<scope>import</scope>
2929
</dependency>

apm-agent-plugins/apm-spring-webflux/apm-spring-webflux-plugin/src/test/java/co/elastic/apm/agent/springwebflux/Spring6ServerAnnotatedInstrumentationTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
package co.elastic.apm.agent.springwebflux;
2020

2121
import co.elastic.apm.agent.testutils.Java17OnlyTest;
22-
import org.junit.jupiter.api.BeforeEach;
2322

2423
public class Spring6ServerAnnotatedInstrumentationTest extends Java17OnlyTest {
2524

@@ -28,10 +27,5 @@ public Spring6ServerAnnotatedInstrumentationTest() {
2827
}
2928

3029
public static class Impl extends ServerAnnotatedInstrumentationTest {
31-
32-
@BeforeEach
33-
void setUp() {
34-
expectedFrameworkVersion = "6.2.0";
35-
}
3630
}
3731
}

apm-agent-plugins/apm-spring-webflux/apm-spring-webflux-plugin/src/test/java/co/elastic/apm/agent/springwebflux/Spring6ServerFunctionalInstrumentationTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
package co.elastic.apm.agent.springwebflux;
2020

2121
import co.elastic.apm.agent.testutils.Java17OnlyTest;
22-
import org.junit.jupiter.api.BeforeEach;
2322

2423
public class Spring6ServerFunctionalInstrumentationTest extends Java17OnlyTest {
2524

@@ -28,9 +27,5 @@ public Spring6ServerFunctionalInstrumentationTest() {
2827
}
2928

3029
public static class Impl extends ServerFunctionalInstrumentationTest {
31-
@BeforeEach
32-
void setUp() {
33-
expectedFrameworkVersion = "6.2.0";
34-
}
3530
}
3631
}

apm-agent-plugins/apm-spring-webflux/apm-spring-webflux-plugin/src/test/java/co/elastic/apm/agent/springwebflux/Spring6ServletContainerTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,9 @@
1818
*/
1919
package co.elastic.apm.agent.springwebflux;
2020

21-
import org.junit.jupiter.api.BeforeEach;
2221
import org.junit.jupiter.api.condition.EnabledForJreRange;
2322
import org.junit.jupiter.api.condition.JRE;
2423

2524
@EnabledForJreRange(min = JRE.JAVA_17)
2625
public class Spring6ServletContainerTest extends ServletContainerTest {
27-
28-
@BeforeEach
29-
void setUp() {
30-
expectedFrameworkVersion = "6.2.0";
31-
}
3226
}

apm-agent-plugins/apm-spring-webflux/apm-spring-webflux-spring5/src/test/java/co/elastic/apm/agent/springwebflux/AbstractServerInstrumentationTest.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import org.junit.jupiter.api.Test;
3939
import org.junit.jupiter.params.ParameterizedTest;
4040
import org.junit.jupiter.params.provider.CsvSource;
41+
import org.springframework.core.SpringVersion;
4142
import org.springframework.http.codec.ServerSentEvent;
4243
import org.springframework.web.reactive.function.client.WebClientResponseException;
4344
import reactor.core.publisher.Hooks;
@@ -58,7 +59,6 @@ public abstract class AbstractServerInstrumentationTest extends AbstractInstrume
5859
private static final String BASIC_AUTH_HEADER_VALUE = "Basic ZWxhc3RpYzpjaGFuZ2VtZQ==";
5960

6061
protected static WebFluxApplication.App app;
61-
protected String expectedFrameworkVersion = "5.3.30";
6262
protected GreetingWebClient client;
6363

6464
@BeforeAll
@@ -134,7 +134,7 @@ private void hello(boolean expectHeaders) {
134134

135135
assertThat(headersCount)
136136
.describedAs("unexpected headers count")
137-
.isEqualTo(6);
137+
.isGreaterThanOrEqualTo(6);
138138

139139
assertThat(headers.getFirst("random-value"))
140140
.describedAs("non-standard request headers should be captured")
@@ -452,11 +452,7 @@ protected ErrorCaptureImpl getFirstError() {
452452
return reporter.getFirstError(200);
453453
}
454454

455-
TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus) {
456-
return checkTransaction(transaction, expectedName, expectedMethod, expectedStatus, expectedFrameworkVersion);
457-
}
458-
459-
static TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus, String expectedFrameworkVersion) {
455+
static TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus) {
460456
assertThat(transaction.getType()).isEqualTo("request");
461457
assertThat(transaction.getNameAsString()).isEqualTo(expectedName);
462458

@@ -473,7 +469,8 @@ static TransactionImpl checkTransaction(TransactionImpl transaction, String expe
473469
.isEqualTo("Spring Webflux");
474470

475471
assertThat(transaction.getFrameworkVersion())
476-
.isEqualTo(expectedFrameworkVersion);
472+
.isNotBlank()
473+
.isEqualTo(SpringVersion.getVersion());
477474

478475
return transaction;
479476
}

apm-agent-plugins/apm-spring-webflux/apm-spring-webflux-spring5/src/test/java/co/elastic/apm/agent/springwebflux/ServletContainerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public class ServletContainerTest extends AbstractInstrumentationTest {
3434

3535
protected static WebFluxApplication.App app;
3636
protected static GreetingWebClient client;
37-
protected String expectedFrameworkVersion = "5.3.30";
3837

3938
@BeforeAll
4039
static void startApp() {
@@ -75,7 +74,7 @@ void shouldOnlyCreateOneTransaction() throws InterruptedException {
7574
TransactionImpl transaction = reporter.getFirstTransaction(200);
7675

7776
// transaction naming should be set by webflux instrumentation
78-
AbstractServerInstrumentationTest.checkTransaction(transaction, "GET /functional/with-parameters/{id}", "GET", 200, expectedFrameworkVersion);
77+
AbstractServerInstrumentationTest.checkTransaction(transaction, "GET /functional/with-parameters/{id}", "GET", 200);
7978

8079
// transaction HTTP part should be provided by servlet instrumentation
8180
AbstractServerInstrumentationTest.checkUrl(client, transaction, "/with-parameters/42");

apm-agent-plugins/apm-spring-webflux/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
<!-- spring boot version to use for dependency management & testing -->
2020
<version.spring-boot-2>2.7.16</version.spring-boot-2>
21-
<version.spring-boot-3>3.4.0</version.spring-boot-3>
21+
<version.spring-boot-3>3.4.1</version.spring-boot-3>
2222
</properties>
2323

2424
<modules>

apm-agent-plugins/apm-spring-webmvc/apm-spring-webmvc-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<!-- Import dependency management from Spring Boot -->
2323
<groupId>org.springframework.boot</groupId>
2424
<artifactId>spring-boot-dependencies</artifactId>
25-
<version>3.4.0</version> <!-- must be 3.X to correspond to spring 6 -->
25+
<version>3.4.1</version> <!-- must be 3.X to correspond to spring 6 -->
2626
<type>pom</type>
2727
<scope>import</scope>
2828
</dependency>

apm-agent-plugins/apm-spring-webmvc/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<!-- Import dependency management from Spring Boot -->
3030
<groupId>org.springframework.boot</groupId>
3131
<artifactId>spring-boot-dependencies</artifactId>
32-
<version>3.4.0</version> <!-- must be 3.X to correspond to spring 6 -->
32+
<version>3.4.1</version> <!-- must be 3.X to correspond to spring 6 -->
3333
<type>pom</type>
3434
<scope>import</scope>
3535
</dependency>

0 commit comments

Comments
 (0)