Handling flaky test - CompletableFutureTest#testCancelBeforeStart (#2459)

eyalkoren · web-flow · commit 9362105bc26c · 2022-02-08T15:29:32.000+02:00
diff --git a/apm-agent-core/src/test/java/co/elastic/apm/agent/util/CompletableFutureTest.java b/apm-agent-core/src/test/java/co/elastic/apm/agent/util/CompletableFutureTest.java
@@ -69,7 +69,7 @@ void reset() {
     void testCancelBeforeStart() {
         final CompletableFuture<Object> completableFuture = new CompletableFuture<>();
         for (int i = 0; i < NUM_THREADS; i++) {
-            scheduledExecutorService.schedule(new CompletableFutureTester(completableFuture, 5), 200, TimeUnit.MILLISECONDS);
+            scheduledExecutorService.schedule(new CompletableFutureTester(completableFuture, 5), 300, TimeUnit.MILLISECONDS);
         }
         assertThat(completableFuture.cancel(false)).isTrue();
         assertThat(completableFuture.cancel(false)).isFalse();

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ void reset() {`
`69`	`69`	`void testCancelBeforeStart() {`
`70`	`70`	`final CompletableFuture<Object> completableFuture = new CompletableFuture<>();`
`71`	`71`	`for (int i = 0; i < NUM_THREADS; i++) {`
`72`		`- scheduledExecutorService.schedule(new CompletableFutureTester(completableFuture, 5), 200, TimeUnit.MILLISECONDS);`
	`72`	`+ scheduledExecutorService.schedule(new CompletableFutureTester(completableFuture, 5), 300, TimeUnit.MILLISECONDS);`
`73`	`73`	`}`
`74`	`74`	`assertThat(completableFuture.cancel(false)).isTrue();`
`75`	`75`	`assertThat(completableFuture.cancel(false)).isFalse();`