test: synchronizing json spec (#2805)

* test: synchronizing json specs

* test with shared spec JSON

Co-authored-by: apmmachine <[email protected]>
Co-authored-by: Sylvain Juge <[email protected]>

Author: 3 people

apm-agent-core/src/test/java/co/elastic/apm/agent/impl/metadata/ContainerInfoTest.java

@@ -19,17 +19,70 @@
 package co.elastic.apm.agent.impl.metadata;
 
 import co.elastic.apm.agent.util.CustomEnvVariables;
+import com.fasterxml.jackson.databind.JsonNode;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+import specs.TestJsonSpec;
 
 import javax.annotation.Nullable;
 
+import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
 import java.util.Map;
+import java.util.stream.Stream;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 public class ContainerInfoTest extends CustomEnvVariables {
 
+    @ParameterizedTest(name = "{0}")
+    @MethodSource("getCommonPatterns")
+    void testCommonPatterns(String testName, String groupLine, @Nullable String containerId, @Nullable String podId) {
+        SystemInfo systemInfo = createSystemInfo().parseContainerId(groupLine);
+        assertThat(systemInfo).isNotNull();
+        SystemInfo.Container containerInfo = systemInfo.getContainerInfo();
+        if (containerId == null) {
+            assertThat(containerInfo).isNull();
+        } else {
+            assertThat(containerInfo).describedAs("missing container info from '%s'", groupLine).isNotNull();
+            assertThat(containerInfo.getId()).isEqualTo(containerId);
+        }
+        SystemInfo.Kubernetes kubernetesInfo = systemInfo.getKubernetesInfo();
+        if (podId == null) {
+            assertThat(kubernetesInfo).isNull();
+        } else {
+            assertThat(kubernetesInfo).describedAs("missing kubernetes info from '%s'", groupLine).isNotNull();
+            assertThat(kubernetesInfo.getPod()).isNotNull();
+            assertThat(kubernetesInfo.getPod().getUid()).isEqualTo(podId);
+        }
+    }
+
+    static Stream<Arguments> getCommonPatterns() {
+        JsonNode json = TestJsonSpec.getJson("cgroup_parsing.json");
+
+        assertThat(json.isObject())
+            .describedAs("unexpected JSON spec format")
+            .isTrue();
+
+        List<Arguments> args = new ArrayList<>();
+        Iterator<Map.Entry<String, JsonNode>> iterator = json.fields();
+        while(iterator.hasNext()){
+            Map.Entry<String, JsonNode> entry = iterator.next();
+            args.add(Arguments.of(
+                entry.getKey(),
+                entry.getValue().get("groupLine").asText(),
+                entry.getValue().get("containerId").asText(null),
+                entry.getValue().get("podId").asText(null)
+            ));
+        }
+
+        return args.stream();
+    }
+
     @Test
     void testContainerIdParsing() {
         String validId = "3741401135a8d27237e2fb9c0fb2ecd93922c0d1dd708345451e479613f8d4ae";

apm-agent-core/src/test/resources/json-specs/cgroup_parsing.json

@@ -0,0 +1,22 @@
+{
+  "testUnderscores": {
+    "groupLine": "1:name=systemd:/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod90d81341_92de_11e7_8cf2_507b9d4141fa.slice/crio-2227daf62df6694645fee5df53c1f91271546a9560e8600a525690ae252b7f63.scope",
+    "containerId": "2227daf62df6694645fee5df53c1f91271546a9560e8600a525690ae252b7f63",
+    "podId": "90d81341-92de-11e7-8cf2-507b9d4141fa"
+  },
+  "testOpenshiftForm": {
+    "groupLine": "9:freezer:/kubepods.slice/kubepods-pod22949dce_fd8b_11ea_8ede_98f2b32c645c.slice/docker-b15a5bdedd2e7645c3be271364324321b908314e4c77857bbfd32a041148c07f.scope",
+    "containerId": "b15a5bdedd2e7645c3be271364324321b908314e4c77857bbfd32a041148c07f",
+    "podId": "22949dce-fd8b-11ea-8ede-98f2b32c645c"
+  },
+  "testUbuntuCGroup": {
+    "groupLine": "1:name=systemd:/user.slice/user-1000.slice/[email protected]/apps.slice/apps-org.gnome.Terminal.slice/vte-spawn-75bc72bd-6642-4cf5-b62c-0674e11bfc84.scope",
+    "containerId": null,
+    "podId": null
+  },
+  "testAwsEcsCGroup": {
+    "groupLine": "1:name=systemd:/ecs/03752a671e744971a862edcee6195646/03752a671e744971a862edcee6195646-4015103728",
+    "containerId": "03752a671e744971a862edcee6195646-4015103728",
+    "podId": null
+  }
+}