Fix docker GH action (#4159)

* Move env to action

* Move secret access to workflows

* Fix dry-run check

Author: JonasKunz

.github/actions/build-and-publish-docker/action.yml

@@ -10,23 +10,31 @@ inputs:
   dry_run:
     description: If set, generate the docker image but don't publish it
     required: true
-    type: boolean
+  registry:
+    description: 'The docker registry'
+    required: true
+  username:
+    description: 'The docker username'
+    required: true
+  password:
+    description: 'The docker password'
+    required: true
 runs:
   using: "composite"
-  env:
-    SONATYPE_FALLBACK: 1
   steps:
     - name: Log in to the Elastic Container registry
       uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
       with:
-        registry: ${{ secrets.ELASTIC_DOCKER_REGISTRY }}
-        username: ${{ secrets.ELASTIC_DOCKER_USERNAME }}
-        password: ${{ secrets.ELASTIC_DOCKER_PASSWORD }}
+        registry: ${{ inputs.registry }}
+        username: ${{ inputs.username }}
+        password: ${{ inputs.password }}
 
     - name: "Build docker image"
       shell: bash
       run: ./scripts/docker-release/build_docker.sh "${{ inputs.release_version }}"
+      env:
+        SONATYPE_FALLBACK: 1
     - name: "Push docker image"
-      if: ${{ ! inputs.dry_run }}
+      if: ${{ inputs.dry_run == 'false' }}
       shell: bash
       run: ./scripts/docker-release/push_docker.sh "${{ inputs.release_version }}"

.github/workflows/regenerate-docker-images.yml

@@ -39,3 +39,6 @@ jobs:
           release_version: ${{ inputs.version }}
           ref: ${{ inputs.ref }}
           dry_run: ${{ inputs.dry_run }}
+          registry: ${{ secrets.ELASTIC_DOCKER_REGISTRY }}
+          username: ${{ secrets.ELASTIC_DOCKER_USERNAME }}
+          password: ${{ secrets.ELASTIC_DOCKER_PASSWORD }}

.github/workflows/release-step-3.yml

@@ -139,6 +139,9 @@ jobs:
           release_version: "${{ env.RELEASE_VERSION }}"
           ref: ${{ inputs.ref }}
           dry_run: ${{ inputs.dry_run }}
+          registry: ${{ secrets.ELASTIC_DOCKER_REGISTRY }}
+          username: ${{ secrets.ELASTIC_DOCKER_USERNAME }}
+          password: ${{ secrets.ELASTIC_DOCKER_PASSWORD }}
 
   publish-aws-lambda:
     name: "Publish AWS Lambda"