Fix @Traced annotation outcome (#2370)

Author: spinscale

CHANGELOG.asciidoc

@@ -25,6 +25,7 @@ endif::[]
 
 [float]
 ===== Bug fixes
+* Fix `@Traced` annotation to return proper outcome instead of `failed` - {pull}2370[#2370]
 
 [[release-notes-1.x]]
 === Java Agent version 1.x

apm-agent-plugins/apm-api-plugin/src/main/java/co/elastic/apm/agent/pluginapi/TracedInstrumentation.java

@@ -108,7 +108,7 @@ public static void onMethodExit(@Advice.Enter @Nullable Object abstractSpan,
             if (abstractSpan instanceof AbstractSpan<?>) {
                 ((AbstractSpan<?>) abstractSpan)
                     .captureException(t)
-                    .withOutcome(t != null ? Outcome.FAILURE : Outcome.FAILURE)
+                    .withOutcome(t != null ? Outcome.FAILURE : Outcome.SUCCESS)
                     .deactivate()
                     .end();
             }

apm-agent-plugins/apm-api-plugin/src/test/java/co/elastic/apm/api/AnnotationApiTest.java

@@ -124,6 +124,7 @@ void testTracedTransactionAndSpan() {
         assertThat(reporter.getFirstSpan().getType()).isEqualTo("app");
         assertThat(reporter.getFirstSpan().getSubtype()).isEqualTo("subtype");
         assertThat(reporter.getFirstSpan().getAction()).isEqualTo("action");
+        assertThat(reporter.getFirstSpan().getOutcome().toString()).isEqualTo("success");
     }
 
     @Test