Skip to content

Commit 0b8b129

Browse files
authored
Enable span compression by default (#1504)
* Enable span compression by default Disable same_kind compression by default * CHANGELOG
1 parent 44eca82 commit 0b8b129

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

CHANGELOG.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ endif::[]
3939
* Add OpenTelemetry API bridge {pull}1411[#1411]
4040
* Change default for `sanitize_field_names` to sanitize `*auth*` instead of `authorization` {pull}1494[#1494]
4141
* Add `span_stack_trace_min_duration` to replace deprecated `span_frames_min_duration` {pull}1498[#1498]
42+
* Enable exact_match span compression by default {pull}1504[#1504]
4243
4344
[float]
4445
===== Bug fixes

docs/configuration.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,7 @@ NOTE: This config value is being deprecated. Use
718718
[options="header"]
719719
|============
720720
| Environment | Django/Flask | Default
721-
| `ELASTIC_APM_SPAN_COMPRESSION_ENABLED` | `SPAN_COMPRESSION_ENABLED` | `False`
721+
| `ELASTIC_APM_SPAN_COMPRESSION_ENABLED` | `SPAN_COMPRESSION_ENABLED` | `True`
722722
|============
723723

724724
Enable/disable span compression.
@@ -758,7 +758,7 @@ Two spans are considered exact matches if the following attributes are identical
758758
[options="header"]
759759
|============
760760
| Environment | Django/Flask | Default
761-
| `ELASTIC_APM_SPAN_COMPRESSION_SAME_KIND_MAX_DURATION` | `SPAN_COMPRESSION_SAME_KIND_MAX_DURATION` | `"5ms"`
761+
| `ELASTIC_APM_SPAN_COMPRESSION_SAME_KIND_MAX_DURATION` | `SPAN_COMPRESSION_SAME_KIND_MAX_DURATION` | `"0ms"` (disabled)
762762
|============
763763

764764
Consecutive spans to the same destination that are under this threshold will be compressed into a single composite span.

elasticapm/conf/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -611,14 +611,14 @@ class Config(_ConfigBase):
611611
span_stack_trace_min_duration = _DurationConfigValue(
612612
"SPAN_STACK_TRACE_MIN_DURATION", default=timedelta(seconds=0.005), unitless_factor=0.001
613613
)
614-
span_compression_enabled = _BoolConfigValue("SPAN_COMPRESSION_ENABLED", default=False)
614+
span_compression_enabled = _BoolConfigValue("SPAN_COMPRESSION_ENABLED", default=True)
615615
span_compression_exact_match_max_duration = _DurationConfigValue(
616616
"SPAN_COMPRESSION_EXACT_MATCH_MAX_DURATION",
617617
default=timedelta(seconds=0.05),
618618
)
619619
span_compression_same_kind_max_duration = _DurationConfigValue(
620620
"SPAN_COMPRESSION_SAME_KIND_MAX_DURATION",
621-
default=timedelta(seconds=0.005),
621+
default=timedelta(seconds=0),
622622
)
623623
exit_span_min_duration = _DurationConfigValue(
624624
"EXIT_SPAN_MIN_DURATION",

0 commit comments

Comments
 (0)