Skip to content

Commit 2029259

Browse files
authored
Merge branch 'main' into feat/pin-actions
2 parents 534a739 + 54baff8 commit 2029259

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

docs/release-notes/breaking-changes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
navigation_title: "Elastic APM Python Agent"
2+
navigation_title: "Breaking changes"
33
---
44

55
# Elastic APM Python Agent breaking changes [elastic-apm-python-agent-breaking-changes]

docs/release-notes/deprecations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
navigation_title: "Elastic APM Python Agent"
2+
navigation_title: "Deprecations"
33
---
44

55
# Elastic APM Python Agent deprecations [elastic-apm-python-agent-deprecations]

docs/release-notes/known-issues.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
navigation_title: "Elastic APM Python Agent"
2+
navigation_title: "Known issues"
33
---
44

55
# Elastic APM Python Agent known issues [elastic-apm-python-agent-known-issues]

tests/instrumentation/kafka_tests.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,18 @@
5454
def topics():
5555
topics = ["test", "foo", "bar"]
5656
admin_client = KafkaAdminClient(bootstrap_servers=[f"{KAFKA_HOST}:9092"])
57-
admin_client.create_topics([NewTopic(name, num_partitions=1, replication_factor=1) for name in topics])
57+
# since kafka-python 2.1.0 we started to get failures in create_topics because topics were already there despite
58+
# calls to delete_topics. In the meantime we found a proper fix use a big hammer and catch topics handling failures
59+
# https://github.com/dpkp/kafka-python/issues/2557
60+
try:
61+
admin_client.create_topics([NewTopic(name, num_partitions=1, replication_factor=1) for name in topics])
62+
except Exception:
63+
pass
5864
yield topics
59-
admin_client.delete_topics(topics)
65+
try:
66+
admin_client.delete_topics(topics)
67+
except Exception:
68+
pass
6069

6170

6271
@pytest.fixture()

0 commit comments

Comments
 (0)