Skip to content

Commit 5e2ebd3

Browse files
authored
skip flaky test in aioredis (#1143)
The reason for the flakines is as of yet unknown. It looks like the `execute_pubsub` method sometimes isn't instrumented, which might point towards an import-time instrumentation-race. A new version of aioredis will be released soon with completely rewritten internals. The hope is that this issue will go away at that point. Using `pytest.mark.flaky` isn't an option, as `flaky` doesn't support async tests.
1 parent 7f6729e commit 5e2ebd3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tests/instrumentation/asyncio_tests/aioredis_tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,15 @@ async def test_redis_client(instrument, elasticapm_client, redis_conn):
125125
assert len(spans) == 3
126126

127127

128+
@pytest.mark.skip(reason="Test is flaky for some reason, possibly related to import-time instrumentation")
128129
@pytest.mark.integrationtest
129-
async def test_publish_subscribe(instrument, elasticapm_client, redis_conn):
130+
async def test_publish_subscribe_async(instrument, elasticapm_client, redis_conn):
130131
elasticapm_client.begin_transaction("transaction.test")
131132
with capture_span("test_publish_subscribe", "test"):
132133
# publish
133134
await redis_conn.publish("mykey", "a")
134135

135-
#subscribe
136+
# subscribe
136137
await redis_conn.subscribe("mykey")
137138

138139
elasticapm_client.end_transaction("MyView")

0 commit comments

Comments
 (0)