fix repo path and comment out hook until it is available on master (#456)

we're in a bit of a circular dependency here, in that the hook
fails because the commit isn't available in the main repo yet.
To get around this, we need to split it up in two commits

closes #456

Author: beniwohli

.pre-commit-config.yaml

@@ -18,3 +18,7 @@ repos:
     hooks:
     -   id: flake8
         exclude: elasticapm\/utils\/wrapt|build|src|tests|dist|conftest.py|setup.py
+#-   repo: https://github.com/elastic/apm-agent-python
+#    rev: cdfb9f18e0ef405
+#    hooks:
+#    - id: license-header-check

.pre-commit-hooks.yaml

@@ -0,0 +1,7 @@
+-   id: license-header-check
+    name: License header check
+    description: Checks the existance of license headers in all Python files
+    entry: ./tests/scripts/license_headers_check.sh
+    exclude: "(elasticapm\/utils\/wrapt\/.*|tests\/utils\/stacks\/linenos.py)"
+    language: script
+    types: [python]

CHANGELOG.md

@@ -5,6 +5,7 @@
  * fixed an issue with Celery and the prefork worker pool (#444)
  * fixed an issue when running uwsgi without a master process (#446)
  * introduced `IntervalTimer` and use it instead of `threading.Timer` (#452)
+ * added license header check as pre-commit hook (#456)
 
 ## v4.2.1 
 [Check the diff](https://github.com/elastic/apm-agent-python/compare/v4.2.0...v4.2.1)

CONTRIBUTING.md

@@ -40,9 +40,14 @@ Once your changes are ready to submit for review:
      * the automatic code formatter [black](https://black.readthedocs.io/en/stable/)
      * sorting of imports via [isort](https://isort.readthedocs.io/en/latest/)
      * [flake8](http://flake8.pycqa.org/en/latest/)
+     * License header check via custom script
 
     The easiest way to make sure your pull request adheres to the the code style
     is to install [pre-commit](https://pre-commit.com/).
+    
+        pip install pre-commit # or "brew install pre-commit" if you use Homebrew
+        
+        pre-commit install
 
 1. Test your changes
 

Jenkinsfile

@@ -72,7 +72,7 @@ pipeline {
               ./tests/scripts/docker/cleanup.sh
               ./tests/scripts/docker/black.sh
               """, label: "Black code formatting"
-              sh script: 'find . -iname "*.py" -not -path "./elasticapm/utils/wrapt/*" -not -path "./dist/*" -not -path "./build/*" -not -path "./tests/utils/stacks/linenos.py" -print0 | xargs -0 -n 1 grep --files-without-match "Copyright (c) [0-9]..., Elastic"', label: "Copyright notice"
+              sh script: './tests/scripts/license_headers_check.sh', label: "Copyright notice"
             }
           }
         }

tests/scripts/license_headers_check.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+if [[ $# -eq 0 ]]
+  then
+    FILES=$(find . -iname "*.py" -not -path "./elasticapm/utils/wrapt/*" -not -path "./dist/*" -not -path "./build/*" -not -path "./tests/utils/stacks/linenos.py")
+else
+    FILES=$@
+fi
+
+echo ${FILES} | xargs -n 1 grep --files-without-match "Copyright (c) [0-9]..., Elastic"