Skip to content

Commit d478a9a

Browse files
authored
skip pubsub test on redis 2 (#1142)
the pubsub test uses a context manager API that isn't available on redis 2. Also, don't test specific redis 2 versions, only the most recent 2.x
1 parent b080438 commit d478a9a

File tree

6 files changed

+6
-7
lines changed

6 files changed

+6
-7
lines changed

.ci/.jenkins_framework_full.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ FRAMEWORK:
4141
- pymongo-3.4
4242
- pymongo-3.5
4343
- pymongo-newest
44-
- redis-2.8
45-
- redis-2.9
44+
- redis-3
45+
- redis-2
4646
- redis-newest
4747
- psycopg2-2.7
4848
- psycopg2-newest

tests/instrumentation/redis_tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ def test_unix_domain_socket_connection_destination_info():
165165
assert destination_info["address"] == "unix:///some/path"
166166

167167

168+
@pytest.mark.skipif(redis.VERSION < (3,), reason="pubsub not available as context manager in redis-py 2")
168169
@pytest.mark.integrationtest
169170
def test_publish_subscribe(instrument, elasticapm_client, redis_conn):
170171
elasticapm_client.begin_transaction("transaction.test")
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
redis>=2.8,<2.9
1+
redis<3
22
-r reqs-base.txt

tests/requirements/reqs-redis-3.0.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
redis>=2.9,<2.10
1+
redis<4
22
-r reqs-base.txt
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
redis>=2.10
1+
redis
22
-r reqs-base.txt

0 commit comments

Comments
 (0)