Skip to content

Commit dac0629

Browse files
committed
added 3.7-rc to test matrix, and changed how we build the image a bit (#160)
this should hopefully cut down on the proliferation of images on Jenkins closes #160
1 parent 6601ade commit dac0629

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

tests/.jenkins_exclude.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ exclude:
1515
FRAMEWORK: django-master
1616
- PYTHON_VERSION: python-3.4
1717
FRAMEWORK: django-master
18+
- PYTHON_VERSION: python-3.7-rc
19+
FRAMEWORK: django-1.11 # see https://code.djangoproject.com/ticket/28814
1820
- PYTHON_VERSION: pypy-2
1921
FRAMEWORK: django-2.0
2022
- PYTHON_VERSION: pypy-2

tests/.jenkins_python.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ PYTHON_VERSION:
44
- python-3.4
55
- python-3.5
66
- python-3.6
7+
- python-3.7-rc
78
- pypy-2
89
- pypy-3

tests/docker-compose.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ services:
3535
- "6379:6379"
3636

3737
run_tests:
38-
build:
39-
context: .
40-
dockerfile: Dockerfile
38+
image: apm-agent-python:${PYTHON_VERSION}
4139
environment:
4240
MONGODB_HOST: 'mongodb'
4341
REDIS_HOST: 'redis'

tests/scripts/docker/docs.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ set -e
33

44
cd tests
55

6-
docker build -t "lint-docs" -f ./DockerfileDocs .
6+
docker build -t "docs:python" -f ./DockerfileDocs .
77
docker run -e LOCAL_USER_ID=$UID \
88
-v "$(dirname $(pwd))":/app \
9-
-i "lint-docs" \
9+
-i "docs:python" \
1010
make docs

tests/scripts/docker/run_tests.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@ docker_pip_cache="/tmp/cache/pip"
1111

1212
cd tests
1313

14-
docker-compose build --pull --build-arg PYTHON_IMAGE=${1/-/:} run_tests # replace - with : to get the correct docker image
15-
docker-compose run \
14+
echo ${1}
15+
16+
docker build --pull --force-rm --build-arg PYTHON_IMAGE=${1/-/:} -t apm-agent-python:${1} . # replace - with : to get the correct docker image
17+
PYTHON_VERSION=${1} docker-compose run \
1618
-e LOCAL_USER_ID=$UID \
1719
-e PYTHONDONTWRITEBYTECODE=1 -e WEBFRAMEWORK=$2 -e PIP_CACHE=${docker_pip_cache} \
1820
-e WITH_COVERAGE=true \

0 commit comments

Comments
 (0)