You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-sorting of imports via [isort](https://isort.readthedocs.io/en/latest/)
42
+
-[flake8](http://flake8.pycqa.org/en/latest/)
43
+
-License header check via custom script
44
44
45
45
The easiest way to make sure your pull request adheres to the code style
46
46
is to install [pre-commit](https://pre-commit.com/).
@@ -161,8 +161,8 @@ In this example, we will create an instrumentation for the "foo" database, by in
161
161
162
162
1. OPTIONAL: If your instrumented package does not support all Python versions we test with, you can exclude certain combinations by adding them to `.ci/matrix_exclude.yml`:
163
163
164
-
- PYTHON_VERSION: python-3.5 # foo doesn't support Python 3.5
165
-
FRAMEWORK: foo-newest
164
+
-PYTHON_VERSION: python-3.5 # foo doesn't support Python 3.5
165
+
FRAMEWORK: foo-newest
166
166
167
167
### Workflow
168
168
@@ -184,7 +184,7 @@ If you have commit access, the process is as follows:
184
184
where `X.Y.Z` is the version in `elasticapm/version.py`
185
185
1. Open a PR against `main` with these changes
186
186
1. Once the PR is merged, fetch and checkout `upstream/main`
187
-
1. Tag the commit with `git tag -a vX.Y.Z`, for example `git tag -a v1.2.3`.
187
+
1. Tag the commit with `git tag -s vX.Y.Z`, for example `git tag -s v1.2.3`.
188
188
Copy the changelog for the release to the tag message, removing any leading `#`.
189
189
1. Reset the current major branch (`1.x`, `2.x` etc) to point to the current main, e.g. `git branch -f 1.x main`
190
190
1. Push tag upstream with `git push upstream --tags` (and optionally to your own fork as well)
0 commit comments