chore: remove node-pupeteer image for tests & fix release in dry-run mode (#1683)

Author: david-luna

.ci/docker/node-puppeteer/Dockerfile

@@ -40,27 +40,9 @@ jobs:
       - run: '.ci/scripts/lint.sh'
       - run: 'npm run ci:bundlesize'
         id: bundlesize
-# TODO: This fails on forked PRs
-#      - uses: actions/github-script@v6
-#        env:
-#          BUNDLESIZE_PASS: ${{ steps.bundlesize.outputs.bundlesize_pass }}
-#          BUNDLESIZE_FAIL: ${{ steps.bundlesize.outputs.bundlesize_fail }}
-#        with:
-#          script: |
-#            const { BUNDLESIZE_PASS, BUNDLESIZE_FAIL } = process.env;
-#            let state = 'success';
-#            if (BUNDLESIZE_FAIL > 0) {
-#              state = 'failure';
-#            }
-#            github.rest.repos.createCommitStatus({
-#              ...context.repo,
-#              sha: context.sha,
-#              state: state,
-#              context: `${context.workflow} / Bundlesize: ${BUNDLESIZE_PASS} pass / ${BUNDLESIZE_FAIL} fail`,
-#            });
 
-  test-puppeteer:
-    name: Test Puppeteer
+  test:
+    name: Test
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -75,47 +57,45 @@ jobs:
           - '@elastic/apm-rum-vue'
     steps:
       - uses: actions/checkout@v6
-
-      - name: Run puppeteer tests
-        uses: ./.github/workflows/run-test
-        with:
-          goal: 'test'
-          scope: ${{ matrix.scope }}
-          stack-version: ${{ matrix.stack-version }}
-
-  npm-ci:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6
-
       - uses: actions/setup-node@v6
         with:
           node-version-file: '.nvmrc'
-
+      - name: Start Stack
+        run: docker compose -f ./dev-utils/docker-compose.yml up -d fleet-server
+        env:
+          STACK_VERSION: ${{ matrix.stack-version }}
       - name: Install dependencies
         run: npm ci
-
-  all:
-    if: always()
-    runs-on: ubuntu-latest
-    needs:
-      - lint
-      - npm-ci
-      - test-puppeteer
-    steps:
-      - id: check
-        uses: elastic/oblt-actions/check-dependent-jobs@v1
-        with:
-          jobs: ${{ toJSON(needs) }}
-      - run: ${{ steps.check.outputs.is-success }}
+      - name: Run Tests
+        run: npm run test
+        env:
+          SCOPE: ${{ matrix.scope }}
 
   coverage:
     name: Coverage
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
+      - uses: actions/setup-node@v6
+        with:
+          node-version-file: '.nvmrc'
+      - name: Start Stack
+        run: docker compose -f ./dev-utils/docker-compose.yml up -d fleet-server
+        env:
+          STACK_VERSION: 8.19.8
+      - name: Install dependencies
+        run: npm ci
       - name: Run coverage
-        uses: ./.github/workflows/run-test
+        run: npm run coverage
+      # The upload-artifact action fails if the name contains slashes `/` or colons `:`.
+      # This step creates a slugified version that will not contain these characters.
+      - uses: gacts/github-slug@91cb78e803e07ccf88570afeddeabaad93c8f4cb # 1.3.4
+        id: slug
+        with:
+          to-slug: coverage-8.19.8
+      - name: Store test results
+        uses: actions/upload-artifact@v6
         with:
-          goal: 'coverage'
-          stack-version: '8.19.8'
+          name: test-results-${{ steps.slug.outputs.slug }}
+          path: |
+            packages/**/reports/TESTS-*.xml

.ci/docker/node-puppeteer/run-test.sh

@@ -85,7 +85,7 @@ jobs:
           GITHUB_TOKEN: ${{ steps.get_token.outputs.token }}
 
       - id: 'upload-files-version'
-        if: ${{ always() && hashFiles('packages/rum/dist/bundles/*.js') }}
+        if: ${{ inputs.dry-run == false && hashFiles('packages/rum/dist/bundles/*.js') }}
         uses: 'google-github-actions/upload-cloud-storage@v3'
         with:
           parent: false
@@ -97,7 +97,7 @@ jobs:
             cache-control: public,max-age=31536000,immutable
 
       - id: 'upload-files-major-version'
-        if: ${{ always() && hashFiles('packages/rum/dist/bundles/*.js') }}
+        if: ${{ inputs.dry-run == false && hashFiles('packages/rum/dist/bundles/*.js') }}
         uses: 'google-github-actions/upload-cloud-storage@v3'
         with:
           parent: false
@@ -109,7 +109,7 @@ jobs:
             cache-control: public,max-age=604800,immutable
 
       - id: 'upload-file-index'
-        if: ${{ always() && hashFiles('index.html') }}
+        if: ${{ inputs.dry-run == false && hashFiles('index.html') }}
         uses: 'google-github-actions/upload-cloud-storage@v3'
         with:
           parent: false

.github/workflows/ci.yml

@@ -86,7 +86,7 @@ $ npx lerna bootstrap
 Tests fall under unit, integration and end-to-end tests. Before running the test, we have to start the APM server manually since all the APM payload data are sent to the server.
 
 ```sh
-NODEJS_VERSION=<nodeVersion> STACK_VERSION=<version> docker compose -f ./dev-utils/docker-compose.yml up -d apm-server
+NODEJS_VERSION=<nodeVersion> STACK_VERSION=<version> docker compose -f ./dev-utils/docker-compose.yml up -d fleet-server
 # nodeVersion - corresponds to NodeJS version to be used when building the test images
 # version - corresponds to Elastic Stack versions
 ```

.github/workflows/release.yml

@@ -129,40 +129,6 @@ services:
         aliases:
           - wait-for-apm-server
 
-  node-puppeteer:
-    build:
-      context: ../.ci/docker/node-puppeteer
-      args:
-        - NODEJS_VERSION=${NODEJS_VERSION}
-    container_name: node-puppeteer
-    image: docker.elastic.co/observability-ci/node-puppeteer:${NODEJS_VERSION}
-    environment:
-      - HOME=/app
-      - SCOPE=${SCOPE}
-      - STACK_VERSION=${STACK_VERSION}
-      - APM_SERVER_URL=${APM_SERVER_URL}
-      - KIBANA_URL=${KIBANA_URL}
-      - BUILD_NUMBER=${BUILD_NUMBER}
-      - BRANCH_NAME=${BRANCH_NAME}
-      - CI=${CI}
-      - MODE=${MODE}
-      - GOAL=${GOAL}
-      - WORKSPACE=${WORKSPACE}
-      - BASE_DIR=${BASE_DIR}
-    command: /run-test.sh
-    mem_limit: 2000m
-#    cpus: 0.5
-    depends_on:
-      fleet-server:
-        condition: service_healthy
-    volumes:
-      - ..:/app
-    networks:
-      apm:
-        aliases:
-          - node-puppeteer
-    user: ${USER_ID}
-
   node-benchmark:
     build:
       context: ../.ci/docker/node-playwright