Skip to content

Commit 7fd2a8b

Browse files
authored
Complete exit spans spec change (#487)
1 parent 17f11c1 commit 7fd2a8b

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

specs/agents/handling-huge-traces/tracing-spans-compress.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ and they define properties under the `composite` context.
120120

121121
### Effects on metric processing
122122

123-
As laid out in the [span destination spec](tracing-spans-destination.md#contextdestinationserviceresource),
123+
As laid out in the [span destination spec](../tracing-spans-destination.md#contextdestinationserviceresource),
124124
APM Server tracks span destination metrics.
125125
To avoid compressed spans to skew latency metrics and cause throughput metrics to be under-counted,
126126
APM Server will take `composite.count` into account when tracking span destination metrics.
@@ -130,7 +130,7 @@ APM Server will take `composite.count` into account when tracking span destinati
130130
### Eligibility for compression
131131

132132
A span is eligible for compression if all the following conditions are met
133-
1. It's an [exit span](tracing-spans.md#exit-spans)
133+
1. It's an [exit span](../tracing-spans.md#exit-spans)
134134
2. The trace context of this span has not been propagated to a downstream service
135135
3. If the span has `outcome` (i.e., `outcome` is present and it's not `null`) then it should be `success`.
136136
It means spans with outcome indicating an issue of potential interest should not be compressed.

specs/agents/handling-huge-traces/tracing-spans-drop-fast-exit.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ Propagating the trace context to downstream services is also known as out-of-pro
5959
### `discardable` flag
6060

6161
Spans store an additional `discardable` flag in order to determine whether a span can be discarded.
62-
The default value is `true` for [exit spans](tracing-spans.md#exit-spans) and `false` for any other span.
62+
The default value is `true` for [exit spans](../tracing-spans.md#exit-spans) and `false` for any other span.
6363

6464
According to the [limitations](#Limitations),
6565
there are certain situations where the `discardable` flag of a span is set to `false`:

specs/agents/tracing-spans-destination.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ A user-supplied value MUST have the highest precedence, regardless if it was set
8585

8686
**Value**
8787

88-
For all [exit spans](handling-huge-traces/tracing-spans.md#exit-spans), unless the `context.destination.service.resource` field was set by the user to `null` or an empty
88+
For all [exit spans](tracing-spans.md#exit-spans), unless the `context.destination.service.resource` field was set by the user to `null` or an empty
8989
string through API, agents MUST infer the value of this field based on properties that are set on the span.
9090

9191
If no value is set to the `context.destination.service.resource` field, the logic for automatically inferring

tests/agents/json-specs/service_resource_inference.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,20 @@
4141
"expected_resource": null,
4242
"failure_message": "The output for non-exit spans should be `null`"
4343
},
44+
{
45+
"span": {
46+
"exit": "false",
47+
"type": "custom",
48+
"subtype": "proprietary-db",
49+
"context": {
50+
"db": {
51+
"instance": "myInstance"
52+
}
53+
}
54+
},
55+
"expected_resource": null,
56+
"failure_message": "The output for non-exit spans should be `null` even if exit-related context data is set"
57+
},
4458
{
4559
"span": {
4660
"exit": "true",

0 commit comments

Comments
 (0)