Skip to content

Commit b1de91d

Browse files
committed
Make composite.sum the same units as duration
1 parent d1d1613 commit b1de91d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

specs/agents/handling-huge-traces/tracing-spans-compress.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ and they define properties under the `composite` context.
112112
- `composite`
113113
- `count`: The number of compressed spans this composite span represents.
114114
The minimum count is 2 as a composite span represents at least two spans.
115-
- `sum.us`: sum of durations of all compressed spans this composite span represents in microseconds.
116-
Thus `sum.us` is the net duration of all the compressed spans while `duration` is the gross duration (including "whitespace" between the spans).
115+
- `sum`: sum of durations of all compressed spans this composite span represents in milliseconds.
116+
Thus `sum` is the net duration of all the compressed spans while `duration` is the gross duration (including "whitespace" between the spans).
117117
- `compression_strategy`: A string value indicating which compression strategy was used. The valid values are:
118118
- `exact_match` - [Consecutive-Exact-Match compression strategy](tracing-spans-compress.md#consecutive-exact-match-compression-strategy)
119119
- `same_kind` - [Consecutive-Same-Kind compression strategy](tracing-spans-compress.md#consecutive-same-kind-compression-strategy)
@@ -216,11 +216,11 @@ bool tryToCompress(Span sibling) {
216216

217217
if (!isAlreadyComposite) {
218218
composite.count = 1
219-
composite.sumUs = duration
219+
composite.sum = duration
220220
}
221221

222222
++composite.count
223-
composite.sumUs += other.duration
223+
composite.sum += other.duration
224224
return true
225225
}
226226

0 commit comments

Comments
 (0)