Skip to content

Commit e969326

Browse files
authored
Drop destination.service.{name,type} from azure/db (#492)
1 parent 7544c0b commit e969326

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

specs/agents/tracing-instrumentation-azure.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,7 @@ is `foo/bar/baz`.
5151
| APM field | Required? | Format | Notes | Example |
5252
| --------- | --------- | ------ | ----- | ------- |
5353
| `context.destination.address` | yes | URL host | | `accountname.blob.core.windows.net` |
54-
| `context.destination.service.name` | yes | `azureblob` | | |
5554
| `context.destination.service.resource` | yes | `azureblob/<Storage Account Name>` | | `azureblob/accountname` |
56-
| `context.destination.service.type` | yes | `storage` | | |
5755

5856

5957
#### Determining operations
@@ -142,9 +140,7 @@ A new span is created when there is a current transaction, and when a message is
142140
| APM field | Required? | Format | Notes | Example |
143141
| --------- | --------- | ------ | ----- | ------- |
144142
| `context.destination.address` | yes | URL host | | `accountname.queue.core.windows.net` |
145-
| `context.destination.service.name` | yes | `azurequeue` | | |
146143
| `context.destination.service.resource` | yes | `azurequeue/<QueueName>` | | `azurequeue/accountname` |
147-
| `context.destination.service.type` | yes | `messaging` | | |
148144

149145
----
150146

@@ -228,9 +224,7 @@ Entities are similar to rows and properties are similar to columns.
228224
| APM field | Required? | Format | Notes | Example |
229225
| --------- | --------- | ------ | ----- | ------- |
230226
| `context.destination.address` | yes | URL host | | `accountname.table.core.windows.net` |
231-
| `context.destination.service.name` | yes | `azuretable` | | |
232227
| `context.destination.service.resource` | yes | `azuretable/<Storage Account Name>` | | `azuretable/accountname` |
233-
| `context.destination.service.type` | yes | `storage` | | |
234228

235229
#### Determining operations
236230

@@ -288,9 +282,7 @@ The `<ResourceName>` is determined from the path of the URL.
288282
| APM field | Required? | Format | Notes | Example |
289283
| --------- | --------- | ------ | ----- | ------- |
290284
| `context.destination.address` | yes | URL host | | `accountname.file.core.windows.net` |
291-
| `context.destination.service.name` | yes | `azurefile` | | |
292285
| `context.destination.service.resource` | yes | `azurefile/<Storage Account Name>` | | `azurefile/accountname` |
293-
| `context.destination.service.type` | yes | `storage` | | |
294286

295287
#### Determining operations
296288

@@ -370,9 +362,7 @@ A new span is created when there is a current transaction, and when a message is
370362
| APM field | Required? | Format | Notes | Example |
371363
| --------- | --------- | ------ | ----- | ------- |
372364
| `context.destination.address` | yes | URL host | | `namespace.servicebus.windows.net` |
373-
| `context.destination.service.name` | yes | azureservicebus | | |
374365
| `context.destination.service.resource` | yes | azureservicebus/`<Queue>`\|`<Topic>` | | `azurequeue/myqueue`, `azureservicebus/mytopic` |
375-
| `context.destination.service.type` | yes | `messaging` | | |
376366

377367
----
378368

specs/agents/tracing-instrumentation-db.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ The following fields are relevant for database and datastore spans. Where possib
3232
| <hr/> |<hr/>|<hr/>|
3333
|`context.destination.address`|The hostname / address of the database.| :x: |
3434
|`context.destination.port`|The port under which the database is accessible.| :x: |
35-
|`context.destination.service.name`| The `destination.service.name` is used to denote "sameness" of the service. E.g. multiple instances of Oracle databases have all the same name `oracle`. For databases and storages the same value as for the `span.subtype` should be used.| :white_check_mark:|
36-
|`context.destination.service.type`| Should be the same as the `span.type`. Value: `db`| :white_check_mark:|
3735
|`context.destination.service.resource`| Used to detect unique destinations from each service. This field should contain all information that is needed to differentiate different database / storage instances (e.g. in the service map). See details below on how to set this field for specific technologies.| :white_check_mark:|
3836
|`context.destination.cloud.region`| The cloud region in case the datastore is hosted in a public cloud or is a managed datasatore / database. E.g. AWS regions, such as `us-east-1` | :x: |
3937

0 commit comments

Comments
 (0)