Increase timeout on flaky SQS test (#43672) (#43688)

mergify[bot] · faec · web-flow · commit 014abe28a328 · 2025-04-07T15:29:33.000-04:00
`TestCancelWithGrace` in `sqs_test.go` has a timer correctness margin of only 5ms. This is much too low for a reliable test, timers are not guaranteed to have that granularity (especially on CI nodes where there are often execution delays). I saw it "failing" a couple times because it expected a duration of 1.0 seconds and instead got 1.006. This PR increases the acceptable margin to 50ms instead of 5. Closes #43668. (cherry picked from commit 7a95d64) Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
diff --git a/x-pack/filebeat/input/awss3/sqs_test.go b/x-pack/filebeat/input/awss3/sqs_test.go
@@ -274,7 +274,7 @@ func TestCancelWithGrace(t *testing.T) {
 	const (
 		wait    = time.Second
 		tooLong = time.Second
-		tol     = 10 * time.Millisecond
+		tol     = 100 * time.Millisecond
 	)
 	parentCtx, parentCancel := context.WithCancel(context.Background())
 	childCtx, childCancel := cancelWithGrace(parentCtx, wait)

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ func TestCancelWithGrace(t *testing.T) {`
`274`	`274`	`const (`
`275`	`275`	`wait = time.Second`
`276`	`276`	`tooLong = time.Second`
`277`		`- tol = 10 * time.Millisecond`
	`277`	`+ tol = 100 * time.Millisecond`
`278`	`278`	`)`
`279`	`279`	`parentCtx, parentCancel := context.WithCancel(context.Background())`
`280`	`280`	`childCtx, childCancel := cancelWithGrace(parentCtx, wait)`