Skip to content

Commit 6d5ad2d

Browse files
strawgateclaude
andcommitted
fix: resolve lint issues and add changelog fragment
- append.go: apply De Morgan's law (QF1001) - copy_fields.go: lowercase error string (ST1005) - decompress_gzip_field.go: lowercase error string (ST1005) - rename.go: lowercase error string (ST1005) - extract_array.go: remove redundant embedded field selector (QF1008) - Add changelog fragment Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d883a3d commit 6d5ad2d

File tree

6 files changed

+12
-7
lines changed

6 files changed

+12
-7
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
kind: enhancement
2+
summary: Skip unnecessary event.Clone() in 11 processors for single-field operations
3+
component: libbeat
4+
pr:
5+
- https://github.com/elastic/beats/pull/49777

libbeat/processors/actions/append.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func (f *appendProcessor) appendValues(target string, fields []string, values []
128128
}
129129

130130
// replace the existing target with new array
131-
if err := event.Delete(target); err != nil && !(err.Error() == "key not found") {
131+
if err := event.Delete(target); err != nil && err.Error() != "key not found" {
132132
return fmt.Errorf("unable to delete the target field %s due to error: %w", target, err)
133133
}
134134
if _, err := event.PutValue(target, arr); err != nil {

libbeat/processors/actions/copy_fields.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func (f *copyFields) Run(event *beat.Event) (*beat.Event, error) {
7777
for _, field := range f.config.Fields {
7878
err := f.copyField(field.From, field.To, event)
7979
if err != nil {
80-
errMsg := fmt.Errorf("Failed to copy fields in copy_fields processor: %w", err)
80+
errMsg := fmt.Errorf("failed to copy fields in copy_fields processor: %w", err)
8181
f.logger.Debugw(errMsg.Error(), logp.TypeKey, logp.EventType)
8282

8383
if f.config.FailOnError {

libbeat/processors/actions/decompress_gzip_field.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func NewDecompressGzipFields(c *conf.C, log *logp.Logger) (beat.Processor, error
6969
func (f *decompressGzipField) Run(event *beat.Event) (*beat.Event, error) {
7070
err := f.decompressGzipField(event)
7171
if err != nil {
72-
errMsg := fmt.Errorf("Failed to decompress field in decompress_gzip_field processor: %w", err)
72+
errMsg := fmt.Errorf("failed to decompress field in decompress_gzip_field processor: %w", err)
7373
f.log.Debugw(errMsg.Error(), logp.EventType, logp.TypeKey)
7474

7575
if f.config.FailOnError {

libbeat/processors/actions/rename.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func (f *renameFields) Run(event *beat.Event) (*beat.Event, error) {
8383
for _, field := range f.config.Fields {
8484
err := f.renameField(field.From, field.To, event)
8585
if err != nil {
86-
errMsg := fmt.Errorf("Failed to rename fields in processor: %w", err)
86+
errMsg := fmt.Errorf("failed to rename fields in processor: %w", err)
8787
f.logger.Debugw(errMsg.Error(), logp.TypeKey, logp.EventType)
8888

8989
if f.config.FailOnError {

libbeat/processors/extract_array/extract_array.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,12 @@ func isEmpty(v reflect.Value) bool {
115115
}
116116

117117
func (f *extractArrayProcessor) Run(event *beat.Event) (*beat.Event, error) {
118-
iValue, err := event.GetValue(f.config.Field)
118+
iValue, err := event.GetValue(f.Field)
119119
if err != nil {
120-
if f.config.IgnoreMissing && errors.Is(err, mapstr.ErrKeyNotFound) {
120+
if f.IgnoreMissing && errors.Is(err, mapstr.ErrKeyNotFound) {
121121
return event, nil
122122
}
123-
return event, fmt.Errorf("could not fetch value for field %s: %w", f.config.Field, err)
123+
return event, fmt.Errorf("could not fetch value for field %s: %w", f.Field, err)
124124
}
125125

126126
array := reflect.ValueOf(iValue)

0 commit comments

Comments
 (0)