Skip to content

Commit a01f9ad

Browse files
authored
Revert "Skip flaky tests TestStateContinuity, TestBrowserSummaries" (#47215)
* Revert "Skip flaky tests TestStateContinuity, TestBrowserSummaries" This reverts commit 130e2ff. * Make linter happy * Make linter happy
1 parent 93e2ae9 commit a01f9ad

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

x-pack/heartbeat/scenarios/browserbasics_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
)
2424

2525
func TestBrowserSummaries(t *testing.T) {
26-
t.Skip("Skipping flaky test https://github.com/elastic/beats/issues/47159")
2726
t.Parallel()
2827
scenarioDB.RunTagWithSeparateTwists(t, "browser", StdAttemptTwists, func(t *testing.T, mtr *framework.MonitorTestRun, err error) {
2928
all := mtr.Events()
@@ -38,7 +37,8 @@ func TestBrowserSummaries(t *testing.T) {
3837

3938
monStatus, _ := lastEvent.GetValue("monitor.status")
4039
summaryIface, _ := lastEvent.GetValue("summary")
41-
summary := summaryIface.(*jobsummary.JobSummary)
40+
summary, ok := summaryIface.(*jobsummary.JobSummary)
41+
require.True(t, ok, "expected JobSummary result: %T", summaryIface)
4242
require.Equal(t, string(summary.Status), monStatus, "expected summary status and mon status to be equal in event: %v", lastEvent.Fields)
4343

4444
requireOneSummaryPerAttempt(t, all)

x-pack/heartbeat/scenarios/stateloader_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"testing"
99

1010
"github.com/stretchr/testify/assert"
11+
"github.com/stretchr/testify/require"
1112

1213
"github.com/elastic/beats/v7/libbeat/beat"
1314
"github.com/elastic/beats/v7/x-pack/heartbeat/scenarios/framework"
@@ -18,15 +19,16 @@ const numRuns = 2
1819
var esIntegTwists = framework.MultiTwist(TwistAddRunFrom, TwistMultiRun(numRuns))
1920

2021
func TestStateContinuity(t *testing.T) {
21-
t.Skip("Skipping flaky test https://github.com/elastic/beats/issues/47193")
2222
t.Parallel()
2323
scenarioDB.RunAllWithATwist(t, esIntegTwists, func(t *testing.T, mtr *framework.MonitorTestRun, err error) {
2424
events := mtr.Events()
2525
var errors = []*beat.Event{}
2626
var sout string
2727
for _, e := range events {
2828
if message, ok := e.GetValue("synthetics.payload.message"); ok == nil {
29-
sout = sout + "\n" + message.(string)
29+
m, ok := message.(string)
30+
require.True(t, ok)
31+
sout = sout + "\n" + m
3032
}
3133
if _, ok := e.GetValue("error"); ok == nil {
3234
errors = append(errors, e)

0 commit comments

Comments
 (0)