Fix race in add_host_metadata unit test (#47192) (#47203)

Fix the logic used in the add_host_metadata TestDataReload test to guarantee at least one asynchronous call to Run after a feature flag change, which was buggy because its starting counter was measured before the feature flag change instead of after.

(cherry picked from commit 3dd2c38)

Co-authored-by: Fae Charlton <[email protected]>

Author: mergify[bot]

libbeat/processors/add_host_metadata/add_host_metadata_test.go

@@ -582,7 +582,6 @@ func TestDataReload(t *testing.T) {
 	assert.Equal(t, int64(1), info.HostInfoRequestCount.Load())
 	assert.Equal(t, int64(0), info.FQDNRequestCount.Load())
 
-	var previousEventCount = eventCount.Load()
 	// update
 	err = features.UpdateFromConfig(conf.MustNewConfigFrom(map[string]interface{}{
 		"features.fqdn.enabled": true,
@@ -593,7 +592,13 @@ func TestDataReload(t *testing.T) {
 
 	// we should have reloaded the data once
 	// note that with fqdn enabled, we still fetch the host info
+	var previousEventCount = eventCount.Load()
 	assert.EventuallyWithT(t, func(collect *assert.CollectT) {
+		// Causality: there can be up to processingGoroutineCount pending
+		// increments of eventCount from Run calls that already finished.
+		// To guarantee that at least one run has happened since the
+		// feature flag change, our event count must go up by _more_
+		// than that.
 		assert.Greater(collect, eventCount.Load(), previousEventCount+processingGoroutineCount)
 	}, time.Second*5, time.Millisecond)
 
@@ -603,13 +608,13 @@ func TestDataReload(t *testing.T) {
 	assert.Equal(t, int64(1), info.FQDNRequestCount.Load())
 
 	// update back to the original value
-	previousEventCount = eventCount.Load()
 	err = features.UpdateFromConfig(conf.MustNewConfigFrom(map[string]interface{}{
 		"features.fqdn.enabled": false,
 	}))
 	require.NoError(t, err)
 
 	// we should have reloaded the data once more
+	previousEventCount = eventCount.Load()
 	assert.EventuallyWithT(t, func(collect *assert.CollectT) {
 		assert.Greater(collect, eventCount.Load(), previousEventCount+processingGoroutineCount)
 	}, time.Second*5, time.Millisecond)