You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
filebeat/magefile.go marks BuildSystemTestBinary as deprecated for Go integration tests and prints:
"The test binary is now built automatically via TestMain."
Go integration tests now call integration.TestMainWithBuild(m, "filebeat") in filebeat/tests/integration/integration_test.go.
libbeat/tests/integration/framework.go implements TestMainWithBuild and performs testbin.Build(...) automatically before running tests.
Documentation impact:
docs/extend/testing.md still presents mage buildSystemTestBinary as a required step for Go integration tests (# Build the test binary before go test ... -tags integration).
docs/extend/testing.md also states: To create the testing binary run mage buildSystemTestBinary.
filebeat/input/journald/README.md still instructs manual test flow with mage buildSystemTestBinary before the Go integration test command.
These instructions are now outdated for Go integration tests and should be updated to avoid unnecessary/incorrect setup steps.
Suggested Actions
Update docs/extend/testing.md Go integration section to state that test binaries are auto-built via TestMainWithBuild.
Clarify in docs/extend/testing.md that mage buildSystemTestBinary is only required for Python system-test workflows (if applicable), not Go integration tests.
Update filebeat/input/journald/README.md manual integration-test instructions to remove (or explicitly re-scope) the mage buildSystemTestBinary prerequisite for Go integration tests.
Note
🔒 Integrity filter blocked 96 items
The following items were blocked because they don't meet the GitHub integrity level.
#43508search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#44537search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#43006search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#50033search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#40503search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49986search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#50112search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#50111search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#50113search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#50142search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49796search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49850search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49849search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49848search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49503search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
#49870search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
... and 80 more items
To allow these resources, lower min-integrity in your GitHub frontmatter:
Recent code changes in the repository have introduced documentation drift. The following changes need corresponding documentation updates.
Changes Requiring Documentation Updates
1. Go integration tests now auto-build test binaries via
TestMainWithBuild, but docs still requiremage buildSystemTestBinaryCommit(s):
What changed:
filebeat/magefile.gomarksBuildSystemTestBinaryas deprecated for Go integration tests and prints:"The test binary is now built automatically via TestMain."integration.TestMainWithBuild(m, "filebeat")infilebeat/tests/integration/integration_test.go.libbeat/tests/integration/framework.goimplementsTestMainWithBuildand performstestbin.Build(...)automatically before running tests.Documentation impact:
docs/extend/testing.mdstill presentsmage buildSystemTestBinaryas a required step for Go integration tests (# Build the test binarybeforego test ... -tags integration).docs/extend/testing.mdalso states:To create the testing binary run mage buildSystemTestBinary.filebeat/input/journald/README.mdstill instructs manual test flow withmage buildSystemTestBinarybefore the Go integration test command.These instructions are now outdated for Go integration tests and should be updated to avoid unnecessary/incorrect setup steps.
Suggested Actions
docs/extend/testing.mdGo integration section to state that test binaries are auto-built viaTestMainWithBuild.docs/extend/testing.mdthatmage buildSystemTestBinaryis only required for Python system-test workflows (if applicable), not Go integration tests.filebeat/input/journald/README.mdmanual integration-test instructions to remove (or explicitly re-scope) themage buildSystemTestBinaryprerequisite for Go integration tests.Note
🔒 Integrity filter blocked 96 items
The following items were blocked because they don't meet the GitHub integrity level.
search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter:What is this? | From workflow: Docs Patrol
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.