PR review comments

Author: shashank-elastic

tests/test_all_rules.py

@@ -14,7 +14,6 @@
 
 import eql
 import kql
-import yaml
 from marshmallow import ValidationError
 from semver import Version
 
@@ -37,7 +36,7 @@
 from detection_rules.rule_loader import FILE_PATTERN, RULES_CONFIG
 from detection_rules.rule_validators import EQLValidator, KQLValidator
 from detection_rules.schemas import definitions, get_min_supported_stack_version, get_stack_schemas
-from detection_rules.utils import ETC_DIR, INTEGRATION_RULE_DIR, PatchedTemplate, get_path, make_git
+from detection_rules.utils import load_etc_dump, INTEGRATION_RULE_DIR, PatchedTemplate, get_path, make_git
 from detection_rules.version_lock import loaded_version_lock
 
 from .base import BaseRuleTest
@@ -1044,19 +1043,17 @@ def test_event_dataset(self):
     def test_min_stack_version_supported(self):
         failures = []
         # Load supported stack versions from stack-schema-map.yaml
-        stack_map_path = Path(f"{ETC_DIR}/stack-schema-map.yaml")
-        with Path.open(stack_map_path) as f:
-            stack_map = yaml.safe_load(f)
+        stack_map = load_etc_dump(["stack-schema-map.yaml"])
 
-        # Get the minimum supported stack version (as string)
-        min_supported = min([v for v in stack_map if not v.startswith("#") and isinstance(v, str)])
+        # Get the minimum supported stack version as version object
+        min_supported = min(stack_map.keys(), key=lambda v: Version.parse(v))
         # Load all production rules
         for rule in self.all_rules:
             min_stack_version = rule.contents.metadata.get("min_stack_version")
             if not min_stack_version:
                 continue  # skip rules without min_stack_version
             # Compare versions using semantic versioning
-            if Version.parse(min_stack_version) < Version.parse(min_supported):
+            if Version.parse(min_stack_version) < min_supported:
                 failures.append(
                     f"{self.rule_str(rule)} min_stack_version={min_stack_version} < supported={min_supported}"
                 )