Skip to content

Commit 557ac34

Browse files
Fix typo and sort
1 parent 59ba619 commit 557ac34

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

detection_rules/cli_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def rule_prompt( # noqa: PLR0912, PLR0913, PLR0915
170170
required_fields = get_dataclass_required_fields(target_data_subclass)
171171
schema = target_data_subclass.jsonschema()
172172
props = schema["properties"]
173-
required_fields = required_fields + additional_required
173+
required_fields = sorted(required_fields + additional_required)
174174
contents: dict[str, Any] = {}
175175
skipped: list[str] = []
176176

detection_rules/mixins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def get_dataclass_required_fields(cls: Any) -> list[str]:
5050
continue
5151

5252
mm_field = marshmallow_schema.fields.get(dc_field.name)
53-
if mm_field is None or mm_field.required:
53+
if mm_field is None:
5454
continue
5555
if dc_field.default is not dataclasses.MISSING:
5656
continue

0 commit comments

Comments
 (0)