Skip unit test for protected prebuilt-rules on DAC env (#5323)

shashank-elastic · web-flow · commit 5db396f084bf · 2025-11-17T21:41:46.000+05:30
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "detection_rules"
-version = "1.5.12"
+version = "1.5.13"
 description = "Detection Rules is the home for rules used by Elastic Security. This repository is used for the development, maintenance, testing, validation, and release of rules for Elastic Security’s Detection Engine."
 readme = "README.md"
 requires-python = ">=3.12"
diff --git a/tests/test_all_rules.py b/tests/test_all_rules.py
@@ -1112,6 +1112,7 @@ def test_ml_integration_jobs_exist(self):
                 f"The following ({len(failures)}) rules are missing a valid `machine_learning_job_id`:\n{err_msg}"
             )
 
+    @unittest.skipIf(os.environ.get("CUSTOM_RULES_DIR"), "Skipping test for custom rules.")
     def test_preserve_upstream_protected_rule_id_name(self):
         """
         Ensure upstream referenced rule IDs and rule names remain unchanged

Original file line number	Diff line number	Diff line change
`@@ -1112,6 +1112,7 @@ def test_ml_integration_jobs_exist(self):`
`1112`	`1112`	f"The following ({len(failures)}) rules are missing a valid `machine_learning_job_id`:\n{err_msg}"
`1113`	`1113`	`)`
`1114`	`1114`
	`1115`	`+ @unittest.skipIf(os.environ.get("CUSTOM_RULES_DIR"), "Skipping test for custom rules.")`
`1115`	`1116`	`def test_preserve_upstream_protected_rule_id_name(self):`
`1116`	`1117`	`"""`
`1117`	`1118`	`Ensure upstream referenced rule IDs and rule names remain unchanged`