Skip to content

Commit 9921f82

Browse files
Merge branch 'main' into 2700-bug-missing-spaces-between-logic-operators-does-not-raise-error
2 parents 40fb63d + a2b280a commit 9921f82

File tree

1,410 files changed

+62473
-10720
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,410 files changed

+62473
-10720
lines changed

.github/CODEOWNERS

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# detection-rules code owners
22
# POC: Elastic Security Intelligence and Analytics Team
33

4-
tests/**/*.py @brokensound77 @mikaayenson @eric-forte-elastic
5-
detection_rules/ @brokensound77 @mikaayenson @eric-forte-elastic
6-
tests/ @brokensound77 @mikaayenson @eric-forte-elastic
7-
lib/ @brokensound77 @mikaayenson @eric-forte-elastic
8-
rta/ @brokensound77 @mikaayenson @eric-forte-elastic
4+
tests/**/*.py @mikaayenson @eric-forte-elastic @terrancedejesus
5+
detection_rules/ @mikaayenson @eric-forte-elastic @terrancedejesus
6+
tests/ @mikaayenson @eric-forte-elastic @terrancedejesus
7+
lib/ @mikaayenson @eric-forte-elastic @terrancedejesus
8+
rta/ @mikaayenson @eric-forte-elastic @terrancedejesus
9+
hunting/ @mikaayenson @eric-forte-elastic @terrancedejesus
910

1011
# skip rta-mapping to avoid the spam
11-
detection_rules/etc/packages.yaml @brokensound77 @mikaayenson @eric-forte-elastic
12-
detection_rules/etc/*.json @brokensound77 @mikaayenson @eric-forte-elastic
13-
detection_rules/etc/*.json @brokensound77 @mikaayenson @eric-forte-elastic
14-
detection_rules/etc/*/* @brokensound77 @mikaayenson @eric-forte-elastic
15-
12+
detection_rules/etc/packages.yaml @mikaayenson @eric-forte-elastic @terrancedejesus
13+
detection_rules/etc/*.json @mikaayenson @eric-forte-elastic @terrancedejesus
14+
detection_rules/etc/*.json @mikaayenson @eric-forte-elastic @terrancedejesus
15+
detection_rules/etc/*/* @mikaayenson @eric-forte-elastic @terrancedejesus

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 0 additions & 31 deletions
This file was deleted.
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
name: Bug Report
2+
description: Report a bug for the Python/testing components of detection-rules
3+
title: "[Bug] "
4+
labels: ["bug", "Team: TRADE"]
5+
assignees: []
6+
projects: ["elastic/1268"]
7+
8+
body:
9+
- type: textarea
10+
id: bug_description
11+
attributes:
12+
label: Describe the Bug
13+
description: "A clear and concise description of what the bug is."
14+
placeholder: "Describe the bug..."
15+
16+
- type: textarea
17+
id: reproduce_steps
18+
attributes:
19+
label: To Reproduce
20+
description: "Steps to reproduce the behavior:"
21+
placeholder: "1. Go to '...'\n2. Click on '....'\n3. Scroll down to '....'\n4. See error"
22+
23+
- type: textarea
24+
id: expected_behavior
25+
attributes:
26+
label: Expected Behavior
27+
description: "A clear and concise description of what you expected to happen."
28+
placeholder: "Expected behavior..."
29+
30+
- type: textarea
31+
id: screenshots
32+
attributes:
33+
label: Screenshots
34+
description: "If applicable, add screenshots to help explain your problem."
35+
placeholder: "Upload screenshots..."
36+
37+
- type: dropdown
38+
id: os
39+
attributes:
40+
label: Desktop - OS
41+
options:
42+
- Windows
43+
- macOS
44+
- Linux
45+
- other - explain
46+
47+
- type: input
48+
id: version
49+
attributes:
50+
label: Desktop - Version
51+
description: "The version of the operating system."
52+
placeholder: "e.g., 10, 11, Big Sur, Ubuntu 20.04"
53+
54+
- type: textarea
55+
id: additional_context
56+
attributes:
57+
label: Additional Context
58+
description: "Add any other context or explanations about the problem here."
59+
placeholder: "Additional context..."

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 0 additions & 20 deletions
This file was deleted.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
name: Feature Request
2+
description: 'Suggest an idea for this repository (Note: this does not include rule logic).'
3+
title: "[FR] "
4+
labels: ["enhancement", "Team: TRADE"]
5+
assignees: []
6+
projects: ["elastic/1268"]
7+
8+
body:
9+
- type: dropdown
10+
id: feature
11+
attributes:
12+
label: Repository Feature
13+
options:
14+
- Core Repo - (rule management, validation, testing, lib, cicd, etc.)
15+
- Detections-as-Code (DaC) - (primarily custom rule management)
16+
- Hunting Library - (hunt query and markdown generation)
17+
- other - explain
18+
19+
- type: textarea
20+
id: problem_description
21+
attributes:
22+
label: Problem Description
23+
description: "Is your feature request related to a problem? Please describe it clearly and concisely. Ex. I'm always frustrated when [...]"
24+
placeholder: "Describe the problem..."
25+
26+
- type: textarea
27+
id: desired_solution
28+
attributes:
29+
label: Desired Solution
30+
description: "A clear and concise description of what you want to happen."
31+
placeholder: "Describe the solution you want..."
32+
33+
- type: textarea
34+
id: considered_alternatives
35+
attributes:
36+
label: Considered Alternatives
37+
description: "A clear and concise description of any alternative solutions or features you've considered."
38+
placeholder: "Describe any alternatives you've considered..."
39+
40+
- type: textarea
41+
id: additional_context
42+
attributes:
43+
label: Additional Context
44+
description: "Add any other context, explanations or screenshots about the feature request here."
45+
placeholder: "Additional context, explanations, or screenshots..."
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
name: Tune Existing Hunt
2+
description: Suggestion for logic changes to an existing hunt
3+
title: "[Hunt Tuning] Name of Hunt"
4+
labels: ["Hunt: Tuning", "Team: TRADE"]
5+
assignees: []
6+
projects: ["elastic/1268"]
7+
8+
body:
9+
- type: input
10+
id: hunt_link
11+
attributes:
12+
label: Link to hunt
13+
description: "Provide a link to the hunt being recommended."
14+
placeholder: "https://github.com/elastic/detection-hunts/tree/main/hunting/..."
15+
16+
- type: dropdown
17+
id: tuning_type
18+
attributes:
19+
label: Hunt Tuning Type
20+
options:
21+
- False Positives - Reducing benign events mistakenly identified as threats.
22+
- False Negatives - Enhancing detection of true threats that were previously missed.
23+
- Performance - Optimizing resource consumption and execution time of detection hunts.
24+
- Contextual Tuning - Customizing hunts based on specific environment factors.
25+
- Threshold Adjustments - Modifying sensitivity by changing alert triggering thresholds.
26+
- Behavioral Tuning - Refining hunts to better detect deviations from typical behavior.
27+
- Temporal Tuning - Adjusting hunts based on time-based patterns.
28+
- Severity Tuning - Adjusting priority or severity levels of alerts.
29+
- Data Quality - Ensuring integrity and quality of data used by detection hunts.
30+
31+
- type: textarea
32+
id: description
33+
attributes:
34+
label: Description
35+
description: "Provide a detailed description of the suggested changes."
36+
placeholder: "Detailed description..."
37+
38+
- type: textarea
39+
id: example_data
40+
attributes:
41+
label: Example Data
42+
description: "If the query is to be changed, include example JSON data or a screenshot."
43+
placeholder: "Example JSON data or screenshot..."

.github/ISSUE_TEMPLATE/integration-oob-updates.md

Lines changed: 0 additions & 39 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/kibana-updates.md

Lines changed: 0 additions & 28 deletions
This file was deleted.
Lines changed: 93 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
name: New Hunt
2+
description: Suggestions and ideas for new hunts
3+
title: "[New hunt] Name of hunt"
4+
labels: ["Hunt: New", "Team: TRADE"]
5+
assignees: []
6+
projects: ["elastic/1268"]
7+
8+
body:
9+
- type: textarea
10+
id: description
11+
attributes:
12+
label: Description
13+
description: "Provide a detailed description of the activity to be detected."
14+
placeholder: "Detailed description..."
15+
16+
- type: dropdown
17+
id: target_huntset
18+
attributes:
19+
label: Target Huntset
20+
description: "Select the target rulset."
21+
options:
22+
- apm
23+
- cross-platform
24+
- aws
25+
- aws_bedrock
26+
- azure
27+
- azure_openai
28+
- beaconing
29+
- cloud_defend
30+
- cyberparkpas
31+
- ded
32+
- dga
33+
- endpoint
34+
- fim
35+
- gcp
36+
- github
37+
- google_workspace
38+
- kubernetes
39+
- lmd
40+
- o365
41+
- okta
42+
- problemchild
43+
- linux
44+
- macos
45+
- ml
46+
- network
47+
- promotions
48+
- threat_intel
49+
- windows
50+
- other
51+
52+
- type: dropdown
53+
id: hunt_type
54+
attributes:
55+
label: Target hunt Type
56+
description: "Select the target type."
57+
options:
58+
- Custom (KQL or Lucene)
59+
- Machine Learning
60+
- Threshold
61+
- Event Correlation (EQL)
62+
- Indicator Match
63+
- New Terms
64+
- ES|QL
65+
- OSQuery
66+
67+
- type: textarea
68+
id: query
69+
attributes:
70+
label: Query
71+
description: "Provide the query for the hunt (optional)."
72+
placeholder: "Query..."
73+
74+
- type: textarea
75+
id: related_issues_prs
76+
attributes:
77+
label: Related issues or PRs
78+
description: "Link any related issues or PRs (optional)."
79+
placeholder: "Related issues or PRs..."
80+
81+
- type: textarea
82+
id: references
83+
attributes:
84+
label: References
85+
description: "List any references (optional)."
86+
placeholder: "References..."
87+
88+
- type: textarea
89+
id: example_data
90+
attributes:
91+
label: Redacted Example Data
92+
description: "Provide a redacted example JSON data from the actual activity."
93+
placeholder: "Example JSON data..."

0 commit comments

Comments
 (0)