Skip to content

Commit bf3955d

Browse files
comment cleanup
1 parent 34cfb33 commit bf3955d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

detection_rules/rule_validators.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,6 @@ def validate_columns_index_mapping(
698698
f"If not dynamic: expected `{schema_type}`, got `{column_type}`."
699699
)
700700

701-
# Raise an error if there are mismatches
702701
if mismatched_columns:
703702
raise ValueError("Column validation errors:\n" + "\n".join(mismatched_columns))
704703

@@ -826,7 +825,7 @@ def log(val: str) -> None:
826825

827826
query_columns = self.execute_query_against_indices(elastic_client, query, full_index_str, log) # type: ignore[reportUnknownVariableType]
828827

829-
# Validation all fields (columns) are either dynamic fields or correctly mapped
828+
# Validate that all fields (columns) are either dynamic fields or correctly mapped
830829
# against the combined mapping of all the indices
831830
if self.validate_columns_index_mapping(query_columns, combined_mappings):
832831
log("All dynamic columns have proper formatting.")

0 commit comments

Comments
 (0)