Skip to content

Commit df9e285

Browse files
Use env rather than variables
1 parent 8b37fc7 commit df9e285

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/workflows/esql-validation.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ jobs:
1212

1313
steps:
1414
- name: Check out repository
15-
if: ${{ !vars.cloud_id && !vars.api_key }}
15+
if: ${{ !secrets.cloud_id && !secrets.api_key }}
1616
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
1717
with:
1818
path: elastic-container
1919
repository: eric-forte-elastic/elastic-container
2020

2121
- name: Build and run containers
22-
if: ${{ !vars.cloud_id && !vars.api_key }}
22+
if: ${{ !secrets.cloud_id && !secrets.api_key }}
2323
run: |
2424
cd elastic-container
2525
GENERATED_PASSWORD=$(openssl rand -base64 16)
@@ -40,7 +40,7 @@ jobs:
4040
python-version: '3.13'
4141

4242
- name: Get API Key and setup auth
43-
if: ${{ !vars.cloud_id && !vars.api_key }}
43+
if: ${{ !secrets.cloud_id && !secrets.api_key }}
4444
env:
4545
DR_ELASTICSEARCH_URL: "https://localhost:9200"
4646
ES_USER: "elastic"
@@ -64,10 +64,10 @@ jobs:
6464
6565
- name: Validate Test ESQL Rule
6666
env:
67-
DR_CLOUD_ID: ${{ vars.cloud_id }}
68-
DR_KIBANA_URL: ${{ vars.cloud_id == '' && 'https://localhost:5601' || '' }}
69-
DR_ES_USER: ${{ vars.cloud_id == '' && 'elastic' || '' }}
70-
DR_API_KEY: ${{ vars.api_key || vars.DR_API_KEY }}
67+
DR_CLOUD_ID: ${{ secrets.cloud_id }}
68+
DR_KIBANA_URL: ${{ secrets.cloud_id == '' && 'https://localhost:5601' || '' }}
69+
DR_ES_USER: ${{ secrets.cloud_id == '' && 'elastic' || '' }}
70+
DR_API_KEY: ${{ secrets.api_key || env.DR_API_KEY }}
7171
run: |
7272
cd detection-rules
7373
python -m detection_rules dev test esql-remote-validation

0 commit comments

Comments
 (0)