Fix concurrent access to dictionary

Author: reakaleek

src/Elastic.Markdown/HtmlWriter.cs

@@ -186,14 +186,12 @@ public async Task<MarkdownDocument> WriteAsync(IDirectoryInfo outBaseDir, IFileI
 		collector?.Collect(markdown, document, rendered.Html);
 		await writeFileSystem.File.WriteAllTextAsync(path, rendered.Html, ctx);
 
-		if (DocumentationSet.Configuration.Features.LazyLoadNavigation)
-		{
-			var navFilePath = Path.Combine(outBaseDir.FullName, rendered.NavigationFileName);
-			if (!writeFileSystem.File.Exists(navFilePath))
-			{
-				await writeFileSystem.File.WriteAllTextAsync(navFilePath, rendered.FullNavigationPartialHtml, ctx);
-			}
-		}
+		if (!DocumentationSet.Configuration.Features.LazyLoadNavigation)
+			return document;
+
+		var navFilePath = Path.Combine(outBaseDir.FullName, rendered.NavigationFileName);
+		if (!writeFileSystem.File.Exists(navFilePath))
+			await writeFileSystem.File.WriteAllTextAsync(navFilePath, rendered.FullNavigationPartialHtml, ctx);
 		return document;
 	}
 

src/Elastic.Markdown/IO/DocumentationSet.cs

@@ -2,6 +2,7 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
+using System.Collections.Concurrent;
 using System.Collections.Frozen;
 using System.IO.Abstractions;
 using System.Runtime.InteropServices;
@@ -129,7 +130,7 @@ public class DocumentationSet : INavigationLookups, IPositionalNavigation
 
 	public IReadOnlyCollection<IDocsBuilderExtension> EnabledExtensions { get; }
 
-	public Dictionary<string, INavigationRenderResult> NavigationRenderResults { get; } = [];
+	public ConcurrentDictionary<string, INavigationRenderResult> NavigationRenderResults { get; } = [];
 
 	public DocumentationSet(
 		BuildContext context,