Skip to content

Commit 10ee6c4

Browse files
committed
more updates and gh issue templates
1 parent b5b99d2 commit 10ee6c4

File tree

13 files changed

+463
-240
lines changed

13 files changed

+463
-240
lines changed
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
name: "Bug Report"
2+
description: "File a bug report."
3+
labels: ["bug"]
4+
projects: ["elastic/1625"]
5+
body:
6+
- type: "textarea"
7+
id: description
8+
attributes:
9+
label: "Describe the bug"
10+
description: "A clear and concise description of what the bug is. If applicable, add screenshots to help explain your problem."
11+
validations:
12+
required: true
13+
- type: "textarea"
14+
id: expected
15+
attributes:
16+
label: "Expected behavior"
17+
description: "A clear and concise description of what you expected to happen."
18+
validations:
19+
required: true
20+
- type: "textarea"
21+
id: repro
22+
attributes:
23+
label: "Steps to reproduce"
24+
description: "If relevant, provide steps to reproduce the issue."
25+
validations:
26+
required: false
27+
- type: "checkboxes"
28+
id: tooling
29+
attributes:
30+
label: "Tooling"
31+
description: "Select the tool this bug relates to."
32+
options:
33+
- label: "docs-builder"
34+
required: false
35+
- label: "migration tooling"
36+
required: false
37+
- label: "I'm not sure"
38+
required: false
Lines changed: 90 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,90 @@
1+
name: Feature Request
2+
description: Suggest an idea for improving docs-builder.
3+
title: "[Feature Request]: "
4+
labels: ["enhancement"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Thanks for taking the time to suggest an improvement to docs-builder! Please fill out this form as completely as possible.
10+
11+
- type: checkboxes
12+
attributes:
13+
label: Prerequisites
14+
description: Please verify you have completed the following
15+
options:
16+
- label: I have searched existing issues to ensure this feature hasn't already been requested
17+
required: true
18+
- label: I have tested using the latest version of docs-builder
19+
required: true
20+
21+
- type: textarea
22+
id: problem
23+
attributes:
24+
label: What problem are you trying to solve?
25+
description: |
26+
Describe the context and limitation you're encountering. Remember that it might not be obvious to others why this is important!
27+
placeholder: |
28+
Example: When building documentation for my project, I often need to update the revision date at the top of each file. Currently, I have to manually edit each file, which is time-consuming and error-prone.
29+
validations:
30+
required: true
31+
32+
- type: textarea
33+
id: solution
34+
attributes:
35+
label: Proposed Solution
36+
description: |
37+
Describe your proposed solution. Include as much detail as you can, but remember that there might be other solutions we haven't thought of!
38+
placeholder: |
39+
Example: Add a CLI flag --auto-update-revision-date that automatically updates a specified metadata field in all documentation files when building.
40+
validations:
41+
required: true
42+
43+
- type: textarea
44+
id: examples
45+
attributes:
46+
label: Examples and Research
47+
description: |
48+
Please provide any relevant examples, research, or references that support this feature request:
49+
- Similar features in other documentation tools
50+
- Code samples showing how you'd use this feature
51+
- Links to relevant standards or conventions
52+
- Screenshots or diagrams of your proposed solution
53+
placeholder: |
54+
- MkDocs has a similar feature using their `git-revision-date-localized` plugin
55+
- Jekyll's `last_modified_at` plugin demonstrates this functionality
56+
validations:
57+
required: false
58+
59+
- type: textarea
60+
id: alternatives
61+
attributes:
62+
label: Alternative Solutions
63+
description: |
64+
What alternative solutions have you considered or tried? Why aren't they sufficient?
65+
placeholder: |
66+
I've tried using git hooks to update the dates, but this doesn't work well in CI/CD pipelines.
67+
validations:
68+
required: false
69+
70+
- type: textarea
71+
id: additional-context
72+
attributes:
73+
label: Additional Context
74+
description: Add any other context about the feature request here.
75+
placeholder: |
76+
- This would be particularly useful for compliance documentation where revision dates are mandatory
77+
- Could potentially integrate with git history for more accurate dating
78+
validations:
79+
required: false
80+
81+
- type: dropdown
82+
id: priority
83+
attributes:
84+
label: How important is this feature to you?
85+
options:
86+
- Nice to have
87+
- Important
88+
- Critical
89+
validations:
90+
required: true

docs/source/contribute/change-browser.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

docs/source/contribute/index.md

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,28 @@
11
---
22
title: Elastic Docs contribution guide
3-
navigation_title: Contribution guide
3+
navigation_title: Contribute
44
---
55

6-
Want to contribute to the Elastic documentation? You're in the right spot! Select an option below to get started:
6+
Welcome, **contributor**!
77

8-
* I just want to suggest a change --> [Open a docs issue](https://github.com/elastic/docs-content/issues/new?template=internal-request.yaml)
9-
* I want to make a small change to a single page --> [Update the docs in your _web browser_](change-browser.md).
10-
* I want to make a larger change or a change to multiple pages --> [Update the docs in your _code editor_](change-local.md).
8+
Whether you're a technical writer or you've only edited Elastic docs once or twice, you're a valued contributor. Every word matters!
9+
10+
## Contribute to the docs [#contribute]
11+
12+
* Simple bugs and enhancements --> [Contribute on the web](on-the-web.md)
13+
* Complex or multi-page updates --> [Contribute locally](locally.md)
14+
15+
## Report a bug
16+
17+
* It's a **documentation** problem --> [Open a docs issue](https://github.com/elastic/docs-content/issues/new?template=internal-request.yaml) *or* [Fix it myself](locally.md)
18+
* It's a **build tool (docs-builder)** problem --> [Open a bug report](https://github.com/elastic/docs-builder/issues/new?template=bug-report.yaml)
19+
* It's a **migration tooling** problem --> [Open a bug report](https://github.com/elastic/docs-builder/issues/new?template=bug-report.yaml)
20+
21+
## Request an enhancement
22+
23+
* Make the **documentation** better --> [Open a docs issue](https://github.com/elastic/docs-content/issues/new?template=internal-request.yaml)
24+
* Make our **build tool (docs-builder)** better --> [Open a docs-builder issue](https://github.com/elastic/docs-builder/issues/new?template=enhancement.yaml)
25+
26+
## Work on docs-builder
27+
28+
That sounds great! See [development](../development/index.md) to learn how to contribute to our documentation build system.

docs/source/contribute/change-local.md renamed to docs/source/contribute/locally.md

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,20 @@
11
---
2-
title: Build the docs locally
2+
title: Contribute locally
33
---
44

5-
1. Install dependencies
6-
2. Clone repositories
7-
3. Make changes
8-
4. Open a Pull Request
9-
5. Work with CI
10-
6. Get approvals and merge
11-
7. View your changes live on elastic.co
5+
Follow these steps to contribute to Elastic docs.
6+
* [Step 1: Install `docs-builder`](#step-one)
7+
* [Step 2: Clone the `docs-content` repository](#step-two)
8+
* [Step 3: Serve the Documentation](#step-three)
9+
* [Step 4: Open a PR](#step-three)
1210

13-
Follow these instructions to get started with docs-builder on your machine.
11+
## Step 1: Install `docs-builder` [#step-one]
1412

1513
::::{tab-set}
1614

1715
:::{tab-item} macOS
1816

19-
### macOS Installation
17+
### macOS
2018

2119
1. **Download the Binary:**
2220
Download the latest macOS binary from [releases](https://github.com/elastic/docs-builder/releases/latest/):
@@ -40,7 +38,7 @@ Follow these instructions to get started with docs-builder on your machine.
4038

4139
:::{tab-item} Windows
4240

43-
### Windows Installation
41+
### Windows
4442

4543
1. **Download the Binary:**
4644
Download the latest Windows binary from [releases](https://github.com/elastic/docs-builder/releases/latest/):
@@ -64,7 +62,7 @@ Follow these instructions to get started with docs-builder on your machine.
6462

6563
:::{tab-item} Linux
6664

67-
### Linux Installation
65+
### Linux
6866

6967
1. **Download the Binary:**
7068
Download the latest Linux binary from [releases](https://github.com/elastic/docs-builder/releases/latest/):
@@ -88,14 +86,14 @@ Follow these instructions to get started with docs-builder on your machine.
8886

8987
::::
9088

91-
### Clone the `docs-content` Repository
89+
## Clone the `docs-content` Repository [#step-two]
9290

9391
Clone the `docs-content` repository to a directory of your choice:
9492
```sh
9593
git clone https://github.com/elastic/docs-content.git
9694
```
9795

98-
### Serve the Documentation
96+
## Serve the Documentation [#step-three]
9997

10098
1. **Navigate to the cloned repository:**
10199
```sh
@@ -113,3 +111,11 @@ git clone https://github.com/elastic/docs-content.git
113111
```
114112

115113
Now you should be able to view the documentation locally by navigating to http://localhost:5000.
114+
115+
## Step 4: Open a PR [#step-four]
116+
117+
Open a PR. Good luck.
118+
119+
## Step 5: View on elastic.co/docs
120+
121+
soon...
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
title: Contribute on the web
3+
---
4+
5+
:::{warning}
6+
This feature is not supported yet. See [#171](https://github.com/elastic/docs-builder/issues/171) for more information.
7+
:::
8+
9+
1. On the right side of the page you want to edit, select **Edit this page**.
10+
1. Do something on GitHub.
11+
1. Take the dog for a walk.
12+
1. Success!

docs/source/development/link-validation.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ title: Link validation
66
* Infrastructure lives in [docs-infra](https://github.com/elastic/docs-infra).
77

88
The mermaid chart below is currently unsupported.
9+
910
```
1011
flowchart TD
1112
subgraph **Repository Build Process**

docs/source/docset.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,20 @@ subs:
2323
a-global-variable: "This was defined in docset.yml"
2424
toc:
2525
- file: index.md
26+
- folder: contribute
27+
children:
28+
- file: index.md
29+
- file: locally.md
30+
- file: on-the-web.md
2631
- folder: migration
2732
children:
2833
- file: index.md
2934
- file: guide.md
3035
- file: file-structure.md
3136
- file: mapping.md
3237
- file: tabs.md
38+
- file: gh-action.md
3339
- file: codeowner.md
34-
- folder: contribute
35-
children:
36-
- file: index.md
37-
- file: change-browser.md
38-
- file: change-local.md
3940
- folder: configure
4041
children:
4142
- file: index.md

docs/source/index.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,18 @@
11
---
2-
title: Elastic Docs v3
2+
title: Welcome to Elastic Docs v3
33
---
44

5-
You've reached the home of the latest incarnation of the documentation tooling.
5+
Elastic Docs V3 is our next-generation documentation platform designed to improve the experience of learning, using, and contributing to Elastic products. Built on a foundation of modern authoring tools and scalable infrastructure, V3 offers faster builds, streamlined versioning, and enhanced navigation to guide users through Elastic’s complex ecosystem.
6+
7+
**What do you want to do today?**
8+
9+
* [Contribute to Elastic documentation](/contribute/index.html)
10+
* [Learn about migration to Elastic Docs V3](/migration/index.html)
11+
* [Configure content sets in V3](/configure/index.html)
12+
* [Learn about V3 syntax](/syntax/index.html)
13+
* [Contribute to V3 (developer guide)](/development/index.html)
14+
15+
## About this repo
616

717
This repository is host to:
818

@@ -104,7 +114,7 @@ environment:
104114
url: ${{ steps.deployment.outputs.page_url }}
105115
steps:
106116
- uses: actions/checkout@v4
107-
117+
108118
- name: Publish Github
109119
uses: elastic/docs-builder/actions/publish@main
110120
id: deployment

docs/source/migration/gh-action.md

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
---
2+
title: Documentation Freeze GH Action
3+
---
4+
5+
## Overview
6+
This GitHub Action enforces documentation freezes by adding comments to pull requests that modify `.asciidoc` files. It complements the use of `CODEOWNERS` to ensure changes during a freeze period are reviewed and approved by the `@docs-freeze-team`.
7+
8+
## How It Works
9+
1. **Trigger**: The Action is triggered on pull request events (`opened`, `reopened`, or `synchronize`).
10+
2. **Check Changes**: It checks the diff between the latest commits to detect modifications to `.asciidoc` files.
11+
3. **Add Comment**: If changes are detected, the Action posts a comment in the pull request, reminding the contributor of the freeze.
12+
13+
```yaml
14+
name: Comment on PR for .asciidoc changes
15+
16+
on:
17+
pull_request:
18+
types:
19+
- synchronize
20+
- opened
21+
- reopened
22+
23+
jobs:
24+
comment-on-asciidoc-change:
25+
runs-on: ubuntu-latest
26+
27+
steps:
28+
- name: Checkout the repository
29+
uses: actions/checkout@v3
30+
31+
- name: Check for changes in .asciidoc files
32+
id: check-files
33+
run: |
34+
if git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep -E '\.asciidoc$'; then
35+
echo "asciidoc_changed=true" >> $GITHUB_ENV
36+
else
37+
echo "asciidoc_changed=false" >> $GITHUB_ENV
38+
fi
39+
40+
- name: Add a comment if .asciidoc files changed
41+
if: env.asciidoc_changed == 'true'
42+
uses: actions/github-script@v6
43+
with:
44+
script: |
45+
github.rest.issues.createComment({
46+
owner: context.repo.owner,
47+
repo: context.repo.repo,
48+
issue_number: context.payload.pull_request.number,
49+
body: 'It looks like this PR modifies one or more `.asciidoc` files. The documentation is currently under a documentation freeze. Please do not merge this PR. See [link](link) to learn more.'
50+
});
51+
```

0 commit comments

Comments
 (0)