review feedback

kgeller · kgeller · commit 13080af7324c · 2025-07-29T17:05:09.000-04:00
diff --git a/src/Elastic.Markdown/Myst/Directives/Image/ImageBlock.cs b/src/Elastic.Markdown/Myst/Directives/Image/ImageBlock.cs
@@ -68,7 +68,7 @@ public class ImageBlock(DirectiveBlockParser parser, ParserContext context)
 
 	public string? Label { get; private set; }
 
-	private static readonly string[] AllowedUriList = ["epr.elastic.co"];
+	private static readonly HashSet<string> AllowedUriHosts = ["epr.elastic.co"];
 
 	public override void FinalizeAndValidate(ParserContext context)
 	{
@@ -100,7 +100,7 @@ private void ExtractImageUrl(ParserContext context)
 
 		if (Uri.TryCreate(imageUrl, UriKind.Absolute, out var uri) && uri.Scheme.StartsWith("http"))
 		{
-			if (!AllowedUriList.Any(host => uri.Host.Contains(host)))
+			if (!AllowedUriHosts.Contains(uri.Host))
 				this.EmitWarning($"{Directive} is using an external URI: {uri} ");
 
 			Found = true;

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public class ImageBlock(DirectiveBlockParser parser, ParserContext context)`
`68`	`68`
`69`	`69`	`public string? Label { get; private set; }`
`70`	`70`
`71`		`- private static readonly string[] AllowedUriList = ["epr.elastic.co"];`
	`71`	`+ private static readonly HashSet<string> AllowedUriHosts = ["epr.elastic.co"];`
`72`	`72`
`73`	`73`	`public override void FinalizeAndValidate(ParserContext context)`
`74`	`74`	`{`
`@@ -100,7 +100,7 @@ private void ExtractImageUrl(ParserContext context)`
`100`	`100`
`101`	`101`	`if (Uri.TryCreate(imageUrl, UriKind.Absolute, out var uri) && uri.Scheme.StartsWith("http"))`
`102`	`102`	`{`
`103`		`- if (!AllowedUriList.Any(host => uri.Host.Contains(host)))`
	`103`	`+ if (!AllowedUriHosts.Contains(uri.Host))`
`104`	`104`	`this.EmitWarning($"{Directive} is using an external URI: {uri} ");`
`105`	`105`
`106`	`106`	`Found = true;`