Skip to content

Commit 1b54c85

Browse files
authored
Make diff validate return 0 if redirect file does not exist (#1734)
* Make diff validate return 0 if redirect file does not exist * remove other hashFiles usage
1 parent cf31577 commit 1b54c85

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/preview-build.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,6 @@ jobs:
300300
- name: 'Validate redirect rules'
301301
if: >
302302
env.MATCH == 'true'
303-
&& ${{ hashFiles('docs/_redirects.yml', 'docs/redirects.yml') != '' }}
304303
&& github.repository == 'elastic/docs-builder'
305304
&& (
306305
steps.deployment.outputs.result
@@ -315,7 +314,6 @@ jobs:
315314
- name: 'Validate redirect rules'
316315
if: >
317316
env.MATCH == 'true'
318-
&& ${{ hashFiles('docs/_redirects.yml', 'docs/redirects.yml') != '' }}
319317
&& (
320318
github.repository != 'elastic/docs-builder'
321319
&& (

src/tooling/docs-builder/Cli/DiffCommands.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@ public async Task<int> ValidateRedirects([Argument] string? path = null, Cancel
4545
var sourceFile = buildContext.ConfigurationPath;
4646
var redirectFileName = sourceFile.Name.StartsWith('_') ? "_redirects.yml" : "redirects.yml";
4747
var redirectFileInfo = sourceFile.FileSystem.FileInfo.New(Path.Combine(sourceFile.Directory!.FullName, redirectFileName));
48+
if (!redirectFileInfo.Exists)
49+
{
50+
await collector.StopAsync(ctx);
51+
return 0;
52+
}
4853

4954
var redirectFileParser = new RedirectFile(redirectFileInfo, buildContext);
5055
var redirects = redirectFileParser.Redirects;

0 commit comments

Comments
 (0)