Skip to content

Commit 1de3c30

Browse files
authored
Fix crosslinks (#1458)
* Fix crosslinks * Revert to absolute URL * Fix test
1 parent 4f3d110 commit 1de3c30

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/Elastic.Markdown/Myst/Renderers/HtmxLinkInlineRenderer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ protected override void Write(HtmlRenderer renderer, LinkInline link)
3737
_ = renderer.Write('"');
3838
_ = renderer.WriteAttributes(link);
3939

40-
if (link.Url?.StartsWith('/') == true)
40+
if (link.Url?.StartsWith('/') == true || isCrossLink)
4141
{
4242
var currentRootNavigation = link.GetData(nameof(MarkdownFile.NavigationRoot)) as INodeNavigationItem<INavigationModel, INavigationItem>;
4343
var targetRootNavigation = link.GetData($"Target{nameof(MarkdownFile.NavigationRoot)}") as INodeNavigationItem<INavigationModel, INavigationItem>;

src/Elastic.Markdown/Myst/Renderers/WrappedTableRenderer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class WrappedTableRenderer : HtmlTableRenderer
1212
protected override void Write(HtmlRenderer renderer, Table table)
1313
{
1414
// Wrap the table in a div to allow for overflow scrolling
15-
_ = renderer.Write("<div class=\"table-wrapper\" hx-disable=\"true\">");
15+
_ = renderer.Write("<div class=\"table-wrapper\">");
1616
base.Write(renderer, table);
1717
_ = renderer.Write("</div>");
1818
}

tests/Elastic.Markdown.Tests/Inline/InlineLinkTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ Go to [test](kibana://index.md)
150150
public void GeneratesHtml() =>
151151
// language=html
152152
Html.Should().Contain(
153-
"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/">test</a></p>"""
153+
"""<p>Go to <a href="https://docs-v3-preview.elastic.dev/elastic/kibana/tree/main/" hx-select-oob="#main-container" preload="mousedown">test</a></p>"""
154154
);
155155

156156
[Fact]

0 commit comments

Comments
 (0)