Skip to content

Commit 31ccba5

Browse files
authored
Add disable-github-edit-link feature flag (#1642)
1 parent 1a2d1c6 commit 31ccba5

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

src/Elastic.Documentation.Configuration/Builder/FeatureFlags.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@ public bool LazyLoadNavigation
2626
set => _featureFlags["lazy-load-navigation"] = value;
2727
}
2828

29+
public bool DisableGitHubEditLink
30+
{
31+
get => IsEnabled("disable-github-edit-link");
32+
set => _featureFlags["disable-github-edit-link"] = value;
33+
}
34+
2935
private bool IsEnabled(string key)
3036
{
3137
var envKey = $"FEATURE_{key.ToUpperInvariant().Replace('-', '_')}";

src/Elastic.Markdown/Layout/_TableOfContents.cshtml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</version-dropdown>
88
</div>
99
<ul class="mt-6 hidden md:flex items-center lg:block gap-4">
10-
@if (Model.GithubEditUrl is not null)
10+
@if (!string.IsNullOrEmpty(Model.GithubEditUrl))
1111
{
1212
<li class="edit-this-page lg:not-first:mt-1">
1313
<a href="@Model.GithubEditUrl" class="link text-sm" target="_blank">
@@ -17,15 +17,15 @@
1717
Edit this page
1818
</a>
1919
</li>
20-
<li class="report-an-issue lg:not-first:mt-1">
21-
<a href="@Model.ReportIssueUrl" class="link text-sm" target="_blank">
22-
<svg class="link-icon" viewBox="0 0 98 96" xmlns="http://www.w3.org/2000/svg">
23-
<path fill-rule="evenodd" clip-rule="evenodd" d="M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z" fill="currentColor"/>
24-
</svg>
25-
Report an issue
26-
</a>
27-
</li>
2820
}
21+
<li class="report-an-issue lg:not-first:mt-1">
22+
<a href="@Model.ReportIssueUrl" class="link text-sm" target="_blank">
23+
<svg class="link-icon" viewBox="0 0 98 96" xmlns="http://www.w3.org/2000/svg">
24+
<path fill-rule="evenodd" clip-rule="evenodd" d="M48.854 0C21.839 0 0 22 0 49.217c0 21.756 13.993 40.172 33.405 46.69 2.427.49 3.316-1.059 3.316-2.362 0-1.141-.08-5.052-.08-9.127-13.59 2.934-16.42-5.867-16.42-5.867-2.184-5.704-5.42-7.17-5.42-7.17-4.448-3.015.324-3.015.324-3.015 4.934.326 7.523 5.052 7.523 5.052 4.367 7.496 11.404 5.378 14.235 4.074.404-3.178 1.699-5.378 3.074-6.6-10.839-1.141-22.243-5.378-22.243-24.283 0-5.378 1.94-9.778 5.014-13.2-.485-1.222-2.184-6.275.486-13.038 0 0 4.125-1.304 13.426 5.052a46.97 46.97 0 0 1 12.214-1.63c4.125 0 8.33.571 12.213 1.63 9.302-6.356 13.427-5.052 13.427-5.052 2.67 6.763.97 11.816.485 13.038 3.155 3.422 5.015 7.822 5.015 13.2 0 18.905-11.404 23.06-22.324 24.283 1.78 1.548 3.316 4.481 3.316 9.126 0 6.6-.08 11.897-.08 13.526 0 1.304.89 2.853 3.316 2.364 19.412-6.52 33.405-24.935 33.405-46.691C97.707 22 75.788 0 48.854 0z" fill="currentColor"/>
25+
</svg>
26+
Report an issue
27+
</a>
28+
</li>
2929
</ul>
3030
<div class="pt-6 hidden lg:block">
3131
@if (Model.PageTocItems.Count > 0)

src/Elastic.Markdown/Page/Index.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
NavigationHtml = Model.NavigationHtml,
2929
NavigationFileName = Model.NavigationFileName,
3030
UrlPathPrefix = Model.UrlPathPrefix,
31-
GithubEditUrl = Model.GithubEditUrl,
31+
GithubEditUrl = Model.Features.DisableGitHubEditLink ? null : Model.GithubEditUrl,
3232
AllowIndexing = Model.AllowIndexing,
3333
CanonicalBaseUrl = Model.CanonicalBaseUrl,
3434
GoogleTagManager = Model.GoogleTagManager,

0 commit comments

Comments
 (0)