Skip to content

Commit 3377725

Browse files
committed
aha!
1 parent 185a03d commit 3377725

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

src/tooling/docs-builder/Cli/DiffCommands.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,10 @@ public async Task<int> ValidateRedirects([Argument] string? path = null, Cancel
6565
foreach (var notFound in changed.DistinctBy(c => c.FilePath).Where(c => c.ChangeType is GitChangeType.Deleted or GitChangeType.Renamed
6666
&& !redirects.ContainsKey(c is RenamedGitChange renamed ? renamed.OldFilePath : c.FilePath)))
6767
{
68-
_log.LogInformation("Checking {FilePath}", notFound.FilePath);
6968
if (notFound is RenamedGitChange renamed)
7069
{
7170
collector.EmitError(redirectFileInfo.Name,
72-
runningOnCi
73-
? $"A file was renamed to '{renamed.NewFilePath}' but it has no redirect configuration set."
74-
: $"File '{renamed.OldFilePath}' was renamed to '{renamed.NewFilePath}' but it has no redirect configuration set.");
71+
$"File '{renamed.OldFilePath}' was renamed to '{renamed.NewFilePath}' but it has no redirect configuration set.");
7572
}
7673
else if (notFound.ChangeType is GitChangeType.Deleted)
7774
{

src/tooling/docs-builder/Tracking/IntegrationGitRepositoryTracker.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,16 @@
66

77
namespace Documentation.Builder.Tracking;
88

9-
public class IntegrationGitRepositoryTracker(ILogger<IntegrationGitRepositoryTracker> logger, string lookupPath) : IRepositoryTracker
9+
public class IntegrationGitRepositoryTracker(string lookupPath) : IRepositoryTracker
1010
{
11-
private ILogger<IntegrationGitRepositoryTracker> Log { get; } = logger;
1211
private string LookupPath { get; } = $"{lookupPath}/";
1312
public IEnumerable<GitChange> GetChangedFiles()
1413
{
1514
var deletedFiles = Environment.GetEnvironmentVariable("DELETED_FILES") ?? string.Empty;
16-
Log.LogInformation("Deleted files: {File} as deleted in integration build", deletedFiles);
1715
if (!string.IsNullOrEmpty(deletedFiles))
1816
{
1917
foreach (var file in deletedFiles.Split(' ', StringSplitOptions.RemoveEmptyEntries).Where(f => f.StartsWith(LookupPath)))
2018
{
21-
Log.LogInformation("Found {File} as deleted in integration build", file);
2219
yield return new GitChange(file, GitChangeType.Deleted);
2320
}
2421
}
@@ -38,12 +35,10 @@ public IEnumerable<GitChange> GetChangedFiles()
3835
}
3936

4037
var renamedFiles = Environment.GetEnvironmentVariable("RENAMED_FILES");
41-
Log.LogInformation("Renamed files: {File} as deleted in integration build", renamedFiles);
4238
if (!string.IsNullOrEmpty(renamedFiles))
4339
{
4440
foreach (var pair in renamedFiles.Split(' ', StringSplitOptions.RemoveEmptyEntries).Where(f => f.StartsWith(LookupPath)))
4541
{
46-
Log.LogInformation("Found {File} as renamed in integration build", pair);
4742
var parts = pair.Split(':');
4843
if (parts.Length == 2)
4944
yield return new RenamedGitChange(parts[0], parts[1], GitChangeType.Renamed);

0 commit comments

Comments
 (0)