replace temp MarkdownIndexFile property with Index which is now the generic MarkdownFile

Author: Mpdreamz

src/Elastic.Markdown/IO/Navigation/DocumentationGroup.cs

@@ -102,10 +102,7 @@ public class DocumentationGroup : INodeNavigationItem<MarkdownFile, INavigationI
 
 	public Uri NavigationSource { get; set; }
 
-	//TODO remove in favor of index
-	public MarkdownFile MarkdownFileIndex { get; set; }
-
-	public MarkdownFile Index => MarkdownFileIndex;
+	public MarkdownFile Index { get; }
 
 	public string Url => Index.Url;
 
@@ -164,14 +161,14 @@ protected DocumentationGroup(string folderName,
 		// ReSharper enable VirtualMemberCallInConstructor
 		NavigationRoot = toplevelTree;
 		// ReSharper restore VirtualMemberCallInConstructor
-		MarkdownFileIndex = ProcessTocItems(context, toplevelTree, lookups, depth, virtualIndexFile, ref fileIndex, out var groups, out var files, out var navigationItems);
+		Index = ProcessTocItems(context, toplevelTree, lookups, depth, virtualIndexFile, ref fileIndex, out var groups, out var files, out var navigationItems);
 
 		GroupsInOrder = groups;
 		FilesInOrder = files;
 		NavigationItems = navigationItems;
 		Id = ShortId.Create(NavigationSource.ToString(), FolderName);
 
-		FilesInOrder = [.. FilesInOrder.Except([MarkdownFileIndex])];
+		FilesInOrder = [.. FilesInOrder.Except([Index])];
 	}
 
 	private MarkdownFile ProcessTocItems(BuildContext context,
@@ -298,7 +295,7 @@ public async Task Resolve(Cancel ctx = default)
 		await Parallel.ForEachAsync(FilesInOrder, ctx, async (file, token) => await file.MinimalParseAsync(token));
 		await Parallel.ForEachAsync(GroupsInOrder, ctx, async (group, token) => await group.Resolve(token));
 
-		_ = await MarkdownFileIndex.MinimalParseAsync(ctx);
+		_ = await Index.MinimalParseAsync(ctx);
 
 		_resolved = true;
 	}

src/Elastic.Markdown/Slices/HtmlWriter.cs

@@ -67,7 +67,7 @@ private async Task<string> RenderLayout(MarkdownFile markdown, MarkdownDocument
 			reportLinkParameter = new Uri(DocumentationSet.Context.CanonicalBaseUrl, Path.Combine(DocumentationSet.Context.UrlPathPrefix ?? string.Empty, markdown.Url));
 		var reportUrl = $"https://github.com/elastic/docs-content/issues/new?template=issue-report.yaml&link={reportLinkParameter}&labels=source:web";
 
-		var siteName = DocumentationSet.Tree.MarkdownFileIndex.Title ?? "Elastic Documentation";
+		var siteName = DocumentationSet.Tree.Index.Title ?? "Elastic Documentation";
 
 		var legacyPage = LegacyUrlMapper.MapLegacyUrl(markdown.YamlFrontMatter?.MappedPages);
 

src/tooling/docs-assembler/Navigation/GlobalNavigation.cs

@@ -67,12 +67,12 @@ ref int navigationIndex
 						fileNavigationItem.Parent = parent;
 					_ = markdownFiles.Add(fileNavigationItem.Model);
 					break;
-				case DocumentationGroup { MarkdownFileIndex: not null } documentationGroup:
+				case DocumentationGroup documentationGroup:
 					var groupIndex = Interlocked.Increment(ref navigationIndex);
-					documentationGroup.MarkdownFileIndex.NavigationIndex = groupIndex;
+					documentationGroup.Index.NavigationIndex = groupIndex;
 					if (parent is not null)
 						documentationGroup.Parent = parent;
-					_ = markdownFiles.Add(documentationGroup.MarkdownFileIndex);
+					_ = markdownFiles.Add(documentationGroup.Index);
 					UpdateNavigationIndex(markdownFiles, documentationGroup.NavigationItems, documentationGroup, ref navigationIndex);
 					break;
 				default:

tests/Elastic.Markdown.Tests/DocSet/NestedTocTests.cs

@@ -22,14 +22,14 @@ public void InjectsNestedTocsIntoDocumentationSet()
 
 		var parent = nav.Parent;
 
-		// ensure we link back up to main toc in docset yaml
+		// ensure we link back up to the main toc in docset yaml
 		parent.Should().NotBeNull();
 
 		// its parent should be null
 		parent.Parent.Should().BeNull();
 
 		// its parent should point to an index
-		var index = (parent as DocumentationGroup)?.MarkdownFileIndex;
+		var index = (parent as DocumentationGroup)?.Index;
 		index.Should().NotBeNull();
 		index.RelativePath.Should().Be("index.md");