Don't cache failed parsing attempts

Author: reakaleek

src/Elastic.Documentation/AppliesTo/ApplicableToParser.cs

@@ -29,23 +29,20 @@ public static class ApplicableToParser
 	/// <returns>The parsed ApplicableTo object, or null if parsing failed</returns>
 	public static ApplicableTo? ParseApplicableTo(string yaml)
 	{
-		// Check cache first
 		if (ParsedCache.TryGetValue(yaml, out var cached))
 			return cached;
 
-		// Parse and cache the result
 		ApplicableTo? parsed = null;
 		try
 		{
 			parsed = Deserializer.Deserialize<ApplicableTo>(yaml);
+			_ = ParsedCache.TryAdd(yaml, parsed);
 		}
-		catch
+		catch (Exception ex)
 		{
-			// If parsing fails, cache null to avoid retrying
+			System.Diagnostics.Debug.WriteLine($"Failed to parse ApplicableTo YAML: {yaml}. Error: {ex.Message}");
 		}
 
-		// Cache the result (including null for failed parses)
-		_ = ParsedCache.TryAdd(yaml, parsed);
 		return parsed;
 	}
 

src/Elastic.Markdown/Myst/Directives/DirectiveHtmlRenderer.cs

@@ -268,22 +268,7 @@ private static void WriteAppliesSwitch(HtmlRenderer renderer, AppliesSwitchBlock
 	private static void WriteAppliesItem(HtmlRenderer renderer, AppliesItemBlock block)
 	{
 		// Parse the applies_to definition to get the ApplicableTo object
-		ApplicableTo? appliesTo = null;
-		try
-		{
-			appliesTo = ApplicableToParser.ParseApplicableTo(block.AppliesToDefinition);
-			if (appliesTo?.Diagnostics is not null)
-			{
-				foreach (var (severity, message) in appliesTo.Diagnostics)
-					block.Emit(severity, message);
-				appliesTo.Diagnostics = null;
-			}
-		}
-		catch (Exception e)
-		{
-			block.EmitError($"Unable to parse applies_to definition: {block.AppliesToDefinition}", e);
-		}
-
+		var appliesTo = ApplicableToParser.ParseApplicableTo(block.AppliesToDefinition);
 		var slice = AppliesItemView.Create(new AppliesItemViewModel
 		{
 			DirectiveBlock = block,