Run dotnet format ahead of enforcing it through build automation

Author: Mpdreamz

build/Program.cs

@@ -38,7 +38,7 @@ dotnet publish {generatorSource}
 app.Add("notices", async Task<int> (Cancel ctx) =>
 {
 	var packages = await "dotnet thirdlicense --project src/docs-builder/docs-builder.csproj --output NOTICE.txt";
-	var packageLines = packages.Split(Environment.NewLine).Where(l=>l.StartsWith("+"));
+	var packageLines = packages.Split(Environment.NewLine).Where(l => l.StartsWith("+"));
 
 	await File.WriteAllTextAsync("NOTICE.txt",
 		$"""

src/Elastic.Markdown/BuildContext.cs

@@ -52,7 +52,7 @@ public BuildContext(IFileSystem readFileSystem, IFileSystem writeFileSystem, str
 			: WriteFileSystem.DirectoryInfo.New(Path.Combine(Paths.Root.FullName, ".artifacts/docs/html"));
 
 		ConfigurationPath =
-		    ReadFileSystem.FileInfo.New(Path.Combine(SourcePath.FullName, "docset.yml"));
+			ReadFileSystem.FileInfo.New(Path.Combine(SourcePath.FullName, "docset.yml"));
 
 		if (ConfigurationPath.FullName != SourcePath.FullName)
 			SourcePath = ConfigurationPath.Directory!;
@@ -63,7 +63,7 @@ public BuildContext(IFileSystem readFileSystem, IFileSystem writeFileSystem, str
 	private IDirectoryInfo FindDocsFolderFromRoot(IDirectoryInfo rootPath)
 	{
 		if (rootPath.Exists &&
-		    ReadFileSystem.File.Exists(Path.Combine(rootPath.FullName, "docset.yml")))
+			ReadFileSystem.File.Exists(Path.Combine(rootPath.FullName, "docset.yml")))
 			return rootPath;
 
 		var docsFolder = rootPath.EnumerateFiles("docset.yml", SearchOption.AllDirectories).FirstOrDefault();

src/Elastic.Markdown/Diagnostics/DiagnosticsChannel.cs

@@ -73,7 +73,7 @@ public class DiagnosticsCollector(ILoggerFactory loggerFactory, IReadOnlyCollect
 	: IHostedService
 {
 	private readonly IReadOnlyCollection<IDiagnosticsOutput> _outputs =
-		[new LogDiagnosticOutput(loggerFactory.CreateLogger<LogDiagnosticOutput>()), ..outputs];
+		[new LogDiagnosticOutput(loggerFactory.CreateLogger<LogDiagnosticOutput>()), .. outputs];
 
 	public DiagnosticsChannel Channel { get; } = new();
 
@@ -88,7 +88,8 @@ public class DiagnosticsCollector(ILoggerFactory loggerFactory, IReadOnlyCollect
 
 	public Task StartAsync(Cancel ctx)
 	{
-		if (_started is not null) return _started;
+		if (_started is not null)
+			return _started;
 		_started = Task.Run(async () =>
 		{
 			await Channel.WaitToWrite();

src/Elastic.Markdown/Diagnostics/ProcessorDiagnosticExtensions.cs

@@ -15,7 +15,8 @@ public static class ProcessorDiagnosticExtensions
 	public static void EmitError(this InlineProcessor processor, int line, int column, int length, string message)
 	{
 		var context = processor.GetContext();
-		if (context.SkipValidation) return;
+		if (context.SkipValidation)
+			return;
 		var d = new Diagnostic
 		{
 			Severity = Severity.Error,
@@ -32,7 +33,8 @@ public static void EmitError(this InlineProcessor processor, int line, int colum
 	public static void EmitWarning(this InlineProcessor processor, int line, int column, int length, string message)
 	{
 		var context = processor.GetContext();
-		if (context.SkipValidation) return;
+		if (context.SkipValidation)
+			return;
 		var d = new Diagnostic
 		{
 			Severity = Severity.Warning,
@@ -47,7 +49,8 @@ public static void EmitWarning(this InlineProcessor processor, int line, int col
 
 	public static void EmitError(this ParserContext context, int line, int column, int length, string message, Exception? e = null)
 	{
-		if (context.SkipValidation) return;
+		if (context.SkipValidation)
+			return;
 		var d = new Diagnostic
 		{
 			Severity = Severity.Error,
@@ -62,7 +65,8 @@ public static void EmitError(this ParserContext context, int line, int column, i
 
 	public static void EmitWarning(this ParserContext context, int line, int column, int length, string message)
 	{
-		if (context.SkipValidation) return;
+		if (context.SkipValidation)
+			return;
 		var d = new Diagnostic
 		{
 			Severity = Severity.Warning,
@@ -99,7 +103,8 @@ public static void EmitWarning(this BuildContext context, IFileInfo file, string
 
 	public static void EmitError(this IBlockExtension block, string message, Exception? e = null)
 	{
-		if (block.SkipValidation) return;
+		if (block.SkipValidation)
+			return;
 
 		var d = new Diagnostic
 		{
@@ -115,7 +120,8 @@ public static void EmitError(this IBlockExtension block, string message, Excepti
 
 	public static void EmitWarning(this IBlockExtension block, string message)
 	{
-		if (block.SkipValidation) return;
+		if (block.SkipValidation)
+			return;
 
 		var d = new Diagnostic
 		{

src/Elastic.Markdown/DocumentationGenerator.cs

@@ -61,7 +61,8 @@ ILoggerFactory logger
 	{
 		var stateFile = DocumentationSet.OutputStateFile;
 		stateFile.Refresh();
-		if (!stateFile.Exists) return null;
+		if (!stateFile.Exists)
+			return null;
 		var contents = stateFile.FileSystem.File.ReadAllText(stateFile.FullName);
 		return JsonSerializer.Deserialize(contents, SourceGenerationContext.Default.GenerationState);
 	}
@@ -177,7 +178,7 @@ private bool CompilationNotNeeded(GenerationState? generationState, out HashSet<
 		else if (DocumentationSet.LastWrite <= outputSeenChanges)
 		{
 			_logger.LogInformation($"No compilation: no changes since last observed: {generationState.LastSeenChanges} "
-			                       + "Pass --force to force a full regeneration");
+								   + "Pass --force to force a full regeneration");
 			return true;
 		}
 

src/Elastic.Markdown/IO/ConfigurationFile.cs

@@ -86,7 +86,7 @@ public ConfigurationFile(IFileInfo sourceFile, IDirectoryInfo rootPath, BuildCon
 					break;
 			}
 		}
-		Globs = ImplicitFolders.Select(f=> Glob.Parse($"{f}/*.md")).ToArray();
+		Globs = ImplicitFolders.Select(f => Glob.Parse($"{f}/*.md")).ToArray();
 	}
 
 	private List<ITocItem> ReadChildren(KeyValuePair<YamlNode, YamlNode> entry, string parentPath)
@@ -167,7 +167,8 @@ private List<ITocItem> ReadChildren(KeyValuePair<YamlNode, YamlNode> entry, stri
 	{
 		found = false;
 		var file = ReadString(entry);
-		if (file is null) return null;
+		if (file is null)
+			return null;
 
 		var path = Path.Combine(_rootPath.FullName, parentPath.TrimStart('/'), file);
 		if (!_context.ReadFileSystem.FileInfo.New(path).Exists)

src/Elastic.Markdown/IO/DocumentationFolder.cs

@@ -46,7 +46,7 @@ public DocumentationFolder(IReadOnlyCollection<ITocItem> toc,
 			{
 				var children = folder.Children;
 				if (children.Count == 0
-				    && folderLookup.TryGetValue(folder.Path, out var documentationFiles))
+					&& folderLookup.TryGetValue(folder.Path, out var documentationFiles))
 				{
 					children = documentationFiles
 						.Select(d => new TocFile(d.RelativePath, true, []))
@@ -61,7 +61,7 @@ public DocumentationFolder(IReadOnlyCollection<ITocItem> toc,
 		Index ??= FilesInOrder.FirstOrDefault();
 		if (Index != null)
 			FilesInOrder = FilesInOrder.Except(new[] { Index }).ToList();
-		OwnFiles = [..FilesInOrder];
+		OwnFiles = [.. FilesInOrder];
 	}
 
 	public bool HoldsCurrent(MarkdownFile current) =>
@@ -71,7 +71,8 @@ public bool HoldsCurrent(MarkdownFile current) =>
 
 	public async Task Resolve(Cancel ctx = default)
 	{
-		if (_resolved) return;
+		if (_resolved)
+			return;
 
 		await Parallel.ForEachAsync(FilesInOrder, ctx, async (file, token) => await file.MinimalParse(token));
 		await Parallel.ForEachAsync(GroupsInOrder, ctx, async (group, token) => await group.Resolve(token));

src/Elastic.Markdown/IO/DocumentationSet.cs

@@ -54,7 +54,7 @@ public DocumentationSet(BuildContext context)
 		FlatMappedFiles = Files.ToDictionary(file => file.RelativePath, file => file);
 		var folderFiles = Files
 			.GroupBy(file => file.RelativeFolder)
-			.ToDictionary(g=>g.Key, g=>g.ToArray());
+			.ToDictionary(g => g.Key, g => g.ToArray());
 
 		Tree = new DocumentationFolder(Configuration.TableOfContents, FlatMappedFiles, folderFiles);
 	}

src/Elastic.Markdown/IO/MarkdownFile.cs

@@ -97,11 +97,11 @@ private void ReadDocumentInstructions(MarkdownDocument document)
 			_tableOfContent[t.Slug] = t;
 
 		var labels = document.Descendants<DirectiveBlock>()
-			.Select(b=>b.CrossReferenceName)
-			.Where(l=>!string.IsNullOrWhiteSpace(l))
+			.Select(b => b.CrossReferenceName)
+			.Where(l => !string.IsNullOrWhiteSpace(l))
 			.Select(_slugHelper.GenerateSlug)
 			.ToArray();
-		foreach(var label in labels)
+		foreach (var label in labels)
 		{
 			if (!string.IsNullOrEmpty(label))
 				_additionalLabels.Add(label);

src/Elastic.Markdown/IO/Paths.cs

@@ -9,7 +9,7 @@ private static DirectoryInfo RootDirectoryInfo()
 	{
 		var directory = new DirectoryInfo(Directory.GetCurrentDirectory());
 		while (directory != null &&
-		       (directory.GetFiles("*.sln").Length == 0 || directory.GetDirectories(".git").Length == 0))
+			   (directory.GetFiles("*.sln").Length == 0 || directory.GetDirectories(".git").Length == 0))
 			directory = directory.Parent;
 		return directory ?? new DirectoryInfo(Directory.GetCurrentDirectory());
 	}