Refactor and other stuff

Author: theletterf

docs/_docset.yml

@@ -96,7 +96,7 @@ toc:
       - file: code.md
       - file: comments.md
       - file: conditionals.md
-      - file: csv-file.md
+      - file: csv-include.md
       - hidden: diagrams.md
       - file: dropdowns.md
       - file: definition-lists.md

docs/syntax/csv-file.md renamed to docs/syntax/csv-include.md

@@ -1,14 +1,14 @@
 # CSV files
 
-The `{csv-file}` directive allows you to include and render CSV files as formatted tables in your documentation. The directive automatically parses CSV content and renders it using the standard table styles defined in `table.css`.
+The `{csv-include}` directive allows you to include and render CSV files as formatted tables in your documentation. The directive automatically parses CSV content and renders it using the standard table styles defined in `table.css`.
 
 ## Usage
 
 :::::{tab-set}
 
 ::::{tab-item} Output
 
-:::{csv-file} ../_snippets/sample-data.csv
+:::{csv-include} ../_snippets/sample-data.csv
 :caption: Sample user data from the database
 :::
 
@@ -17,7 +17,7 @@ The `{csv-file}` directive allows you to include and render CSV files as formatt
 ::::{tab-item} Markdown
 
 ```markdown
-:::{csv-file} _snippets/sample-data.csv
+:::{csv-include} _snippets/sample-data.csv
 :::
 ```
 
@@ -34,7 +34,7 @@ The CSV file directive supports several options to customize the table rendering
 Add a descriptive caption above the table:
 
 ```markdown
-:::{csv-file} _snippets/sample-data.csv
+:::{csv-include} _snippets/sample-data.csv
 :caption: Sample user data from the database
 :::
 ```
@@ -44,33 +44,25 @@ Add a descriptive caption above the table:
 Specify a custom field separator (default is comma):
 
 ```markdown
-:::{csv-file} _snippets/sample-data.csv
+:::{csv-include} _snippets/sample-data.csv
 :separator: ;
 :::
 ```
 
-### Size and performance limits
+### Performance limits
 
-Control how much data is loaded and displayed:
+The directive includes built-in performance limits to handle large files efficiently:
 
-```markdown
-:::{csv-file} _snippets/large-dataset.csv
-:max-rows: 5000
-:max-columns: 50
-:max-size: 20MB
-:::
-```
-
-- **max-rows**: Maximum number of rows to display (default: 10,000)
-- **max-columns**: Maximum number of columns to display (default: 100)  
-- **max-size**: Maximum file size to process (default: 10MB). Supports KB, MB, GB units.
+- **Row limit**: Maximum of 10,000 rows will be displayed
+- **Column limit**: Maximum of 100 columns will be displayed  
+- **File size limit**: Maximum file size of 10MB
 
 ### Preview mode
 
 For very large files, enable preview mode to show only the first 100 rows:
 
 ```markdown
-:::{csv-file} _snippets/huge-dataset.csv
+:::{csv-include} _snippets/huge-dataset.csv
 :preview-only: true
 :::
 ```
@@ -80,11 +72,10 @@ For very large files, enable preview mode to show only the first 100 rows:
 The CSV directive is optimized for large files:
 
 - Files are processed using streaming to avoid loading everything into memory
-- Size validation prevents processing of files that exceed the specified limits
+- Built-in size validation prevents processing of files that exceed 10MB
 - Row and column limits protect against accidentally rendering massive tables
 - Warning messages are displayed when limits are exceeded
 
 For optimal performance with large CSV files, consider:
-- Setting appropriate `max-rows` and `max-columns` limits
 - Using `preview-only: true` for exploratory data viewing
-- Increasing `max-size` only when necessary
+- Breaking very large files into smaller, more manageable chunks

docs/syntax/index.md

@@ -18,7 +18,7 @@ The following directives are available in Elastic Docs V3:
 
 * [Admonitions](admonitions.md) - Callouts and warnings
 * [Code blocks](code.md) - Syntax-highlighted code
-* [CSV file](csv-file.md) - Render CSV files as tables
+* [CSV include](csv-include.md) - Render CSV files as tables
 * [Diagrams](diagrams.md) - Visual diagrams and charts
 * [Dropdowns](dropdowns.md) - Collapsible content
 * [Images](images.md) - Enhanced image handling

src/Elastic.Markdown/Myst/Directives/CsvFile/CsvFileView.cshtml

@@ -6,11 +6,11 @@
 using System.IO.Abstractions;
 using Elastic.Markdown.Diagnostics;
 
-namespace Elastic.Markdown.Myst.Directives.CsvFile;
+namespace Elastic.Markdown.Myst.Directives.CsvInclude;
 
-public class CsvFileBlock(DirectiveBlockParser parser, ParserContext context) : DirectiveBlock(parser, context)
+public class CsvIncludeBlock(DirectiveBlockParser parser, ParserContext context) : DirectiveBlock(parser, context)
 {
-	public override string Directive => "csv-file";
+	public override string Directive => "csv-include";
 
 	public string? CsvFilePath { get; private set; }
 	public string? CsvFilePathRelativeToSource { get; private set; }
@@ -30,15 +30,6 @@ public override void FinalizeAndValidate(ParserContext context)
 		if (!string.IsNullOrEmpty(separator))
 			Separator = separator;
 
-		if (int.TryParse(Prop("max-rows"), out var maxRows) && maxRows > 0)
-			MaxRows = maxRows;
-
-		if (ParseFileSize(Prop("max-size"), out var maxSize) && maxSize > 0)
-			MaxFileSizeBytes = maxSize;
-
-		if (int.TryParse(Prop("max-columns"), out var maxColumns) && maxColumns > 0)
-			MaxColumns = maxColumns;
-
 		PreviewOnly = bool.TryParse(Prop("preview-only"), out var preview) && preview;
 
 		ExtractCsvPath(context);
@@ -49,7 +40,7 @@ private void ExtractCsvPath(ParserContext context)
 		var csvPath = Arguments;
 		if (string.IsNullOrWhiteSpace(csvPath))
 		{
-			this.EmitError("csv-file requires an argument specifying the path to the CSV file.");
+			this.EmitError("csv-include requires an argument specifying the path to the CSV file.");
 			return;
 		}
 
@@ -81,7 +72,7 @@ private void ValidateFileSize()
 			{
 				var sizeMB = fileInfo.Length / (1024.0 * 1024.0);
 				var maxSizeMB = MaxFileSizeBytes / (1024.0 * 1024.0);
-				this.EmitError($"CSV file `{CsvFilePath}` is {sizeMB:F1}MB, which exceeds the maximum allowed size of {maxSizeMB:F1}MB. Use :max-size to increase the limit.");
+				this.EmitError($"CSV file `{CsvFilePath}` is {sizeMB:F1}MB, which exceeds the maximum allowed size of {maxSizeMB:F1}MB.");
 				Found = false;
 			}
 		}
@@ -91,39 +82,4 @@ private void ValidateFileSize()
 			Found = false;
 		}
 	}
-
-	private static bool ParseFileSize(string? sizeString, out long bytes)
-	{
-		bytes = 0;
-		if (string.IsNullOrEmpty(sizeString))
-			return false;
-
-		var multiplier = 1L;
-		var value = sizeString.ToUpperInvariant();
-
-		if (value.EndsWith("KB"))
-		{
-			multiplier = 1024;
-			value = value[..^2];
-		}
-		else if (value.EndsWith("MB"))
-		{
-			multiplier = 1024 * 1024;
-			value = value[..^2];
-		}
-		else if (value.EndsWith("GB"))
-		{
-			multiplier = 1024 * 1024 * 1024;
-			value = value[..^2];
-		}
-
-		if (double.TryParse(value, out var numericValue))
-		{
-			bytes = (long)(numericValue * multiplier);
-			return true;
-		}
-
-		return false;
-	}
-
 }

src/Elastic.Markdown/Myst/Directives/CsvFile/CsvFileViewModel.cs

@@ -0,0 +1,46 @@
+@using Elastic.Markdown.Myst.Directives.CsvInclude
+@inherits RazorSlice<CsvIncludeViewModel>
+
+@{
+    var csvBlock = (CsvIncludeBlock)Model.DirectiveBlock;
+    if (!csvBlock.Found)
+    {
+        return;
+    }
+    
+    var csvRows = Model.GetCsvRows().ToList();
+    if (!csvRows.Any())
+    {
+        return;
+    }
+}
+
+<div class="table-wrapper">
+    @if (!string.IsNullOrEmpty(csvBlock.Caption))
+    {
+        <caption>@csvBlock.Caption</caption>
+    }
+    
+    <table>
+        <thead>
+            <tr>
+                @for (var i = 0; i < csvRows[0].Length; i++)
+                {
+                    <th>@csvRows[0][i]</th>
+                }
+            </tr>
+        </thead>
+        
+        <tbody>
+            @for (var rowIndex = 1; rowIndex < csvRows.Count; rowIndex++)
+            {
+                <tr>
+                    @for (var i = 0; i < csvRows[rowIndex].Length; i++)
+                    {
+                        <td>@csvRows[rowIndex][i]</td>
+                    }
+                </tr>
+            }
+        </tbody>
+    </table>
+</div>